Skip to content

feat: pair Testbench with Laravel version - #29

Merged
rivanuff merged 1 commit into
mainfrom
feat/pair-laravel-testbench
Sep 2, 2026
Merged

feat: pair Testbench with Laravel version#29
rivanuff merged 1 commit into
mainfrom
feat/pair-laravel-testbench

Conversation

@rivanuff

@rivanuff rivanuff commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Derives orchestra/testbench from the Laravel matrix value (L10->8, L11->9, L12->10) so consumers can test multiple Laravel majors without invalid cross-product combos. Backward compatible: existing single-value callers resolve to the same pair. The testbench-versions input remains declared but unused.

Update: both run-laravel-testbench-tests.yml and run-pest-tests.yml now derive the PHP matrix from composer.json via typisttech/php-matrix-action, and cover the dependency range via composer update (highest) vs composer update --prefer-lowest (lowest) instead of pinning explicit Laravel/testbench combinations. The php-versions, laravel-versions, and testbench-versions inputs are now deprecated/ignored (kept for backward compatibility). The two workflows have converged on the same job structure.

Copilot AI lite review requested due to automatic review settings September 1, 2026 13:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the reusable GitHub Actions workflow to derive the orchestra/testbench version from the selected Laravel version in the matrix, preventing invalid Laravel/Testbench cross-product combinations when testing multiple Laravel majors.

Changes:

  • Removes testbench from the strategy matrix (no longer sourced from inputs.testbench-versions).
  • Adds a shell case mapping from matrix.laravel to an appropriate Testbench constraint and uses it during composer require.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/run-laravel-testbench-tests.yml Outdated
@rivanuff
rivanuff force-pushed the feat/pair-laravel-testbench branch 2 times, most recently from 1b84422 to 374fafe Compare September 1, 2026 14:01
@rivanuff
rivanuff requested review from a team, Rovasch, ShunLuk, SimonvanWijhe, dtakken, ictbeheer and mvdhoek1 and removed request for a team September 1, 2026 14:05
@rivanuff
rivanuff force-pushed the feat/pair-laravel-testbench branch 2 times, most recently from 09c9b45 to bde1760 Compare September 1, 2026 14:18
@rivanuff
rivanuff requested a review from a team September 1, 2026 14:44
@ictbeheer

Copy link
Copy Markdown
Member

@SimonvanWijhe en @rivanuff ik zou dit juist minder complex willen maken. Is dit alleen nodig om Acorn 4 compatibiliteit te behouden? Kunnen we het anders niet afkijken van spatie: https://github.com/spatie/laravel-data/actions/runs/33497179425/workflow

@rivanuff
rivanuff force-pushed the feat/pair-laravel-testbench branch 3 times, most recently from 292d241 to e50e179 Compare September 2, 2026 10:46
@rivanuff
rivanuff force-pushed the feat/pair-laravel-testbench branch from e50e179 to 57b69df Compare September 2, 2026 11:20
@rivanuff
rivanuff merged commit 8299062 into main Sep 2, 2026
@rivanuff
rivanuff deleted the feat/pair-laravel-testbench branch September 2, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants