feat: pair Testbench with Laravel version - #29
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the reusable GitHub Actions workflow to derive the orchestra/testbench version from the selected Laravel version in the matrix, preventing invalid Laravel/Testbench cross-product combinations when testing multiple Laravel majors.
Changes:
- Removes
testbenchfrom the strategy matrix (no longer sourced frominputs.testbench-versions). - Adds a shell
casemapping frommatrix.laravelto an appropriate Testbench constraint and uses it duringcomposer require.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
rivanuff
force-pushed
the
feat/pair-laravel-testbench
branch
2 times, most recently
from
September 1, 2026 14:01
1b84422 to
374fafe
Compare
rivanuff
requested review from
a team,
Rovasch,
ShunLuk,
SimonvanWijhe,
dtakken,
ictbeheer and
mvdhoek1
and removed request for
a team
September 1, 2026 14:05
rivanuff
force-pushed
the
feat/pair-laravel-testbench
branch
2 times, most recently
from
September 1, 2026 14:18
09c9b45 to
bde1760
Compare
This was referenced Sep 1, 2026
Merged
Merged
Merged
Merged
Member
|
@SimonvanWijhe en @rivanuff ik zou dit juist minder complex willen maken. Is dit alleen nodig om Acorn 4 compatibiliteit te behouden? Kunnen we het anders niet afkijken van spatie: https://github.com/spatie/laravel-data/actions/runs/33497179425/workflow |
rivanuff
force-pushed
the
feat/pair-laravel-testbench
branch
3 times, most recently
from
September 2, 2026 10:46
292d241 to
e50e179
Compare
rivanuff
force-pushed
the
feat/pair-laravel-testbench
branch
from
September 2, 2026 11:20
e50e179 to
57b69df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derives orchestra/testbench from the Laravel matrix value (L10->8, L11->9, L12->10) so consumers can test multiple Laravel majors without invalid cross-product combos. Backward compatible: existing single-value callers resolve to the same pair. The testbench-versions input remains declared but unused.
Update: both
run-laravel-testbench-tests.ymlandrun-pest-tests.ymlnow derive the PHP matrix fromcomposer.jsonviatypisttech/php-matrix-action, and cover the dependency range viacomposer update(highest) vscomposer update --prefer-lowest(lowest) instead of pinning explicit Laravel/testbench combinations. Thephp-versions,laravel-versions, andtestbench-versionsinputs are now deprecated/ignored (kept for backward compatibility). The two workflows have converged on the same job structure.