fix(ci): report the docs URL from the config, not from wrangler's log - #40
Merged
Conversation
`docs-v2026.901.0` published its release notes as:
- url: docs.getprick.dev (custom domain)
and GitHub refused the same string as the deployment's environment URL:
Environment URL 'docs.getprick.dev (custom domain)' is not a valid
http(s) URL, so it will not be shown as a link in the workflow graph.
wrangler-action derives `deployment-url` by scraping the deploy log, and for a
Worker on a custom domain the line it finds is a trigger DESCRIPTION rather
than a URL. The previous commit anticipated that output going empty once
workers.dev was switched off and added `|| steps.site.outputs.url` as a
fallback. That was the wrong shape of guard: the output is not empty, it is
non-empty and wrong, so the fallback never fired.
So stop consulting it. The environment URL, the job summary and the release
notes all take the hostname read out of `scripts/docs.mjs`, which
`scripts/docs.test.mjs` already ties to the `routes` block in
packages/docs/wrangler.jsonc and to `site` in its astro.config.ts. That route
is the only place a deploy can land, so it is a fact about the release rather
than a guess at one.
`DEPLOY_URL` is renamed `SITE_URL` in both jobs: it no longer holds what the
deploy reported, and a name that says otherwise is how the next reader repeats
this. The comment justifying the environment hop said the value was "an action
output and so is not ours to trust", which stopped being true with it.
Only the notes of releases cut from this commit onward are affected;
docs-v2026.901.0's have been corrected in place.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #39, fixing a defect it shipped.
What went wrong
docs-v2026.901.0deployed correctly — https://docs.getprick.dev is live — butpublished its notes as:
and GitHub rejected the same string as the deployment's environment URL:
wrangler-action derives
deployment-urlby scraping the deploy log, and for aWorker on a custom domain the line it finds is a trigger description, not a
URL.
#39 anticipated that output going empty once workers.dev was switched off, and
guarded with
|| steps.site.outputs.url. That was the wrong shape of guard —the output is not empty, it is non-empty and wrong, so the fallback never fired.
The fix
Stop consulting it. The environment URL, the job summary and the release notes
all take the hostname read out of
scripts/docs.mjs, whichscripts/docs.test.mjsalready ties to theroutesblock inpackages/docs/wrangler.jsoncand tositein itsastro.config.ts. That routeis the only place a deploy can land, so it is a fact about the release rather
than a guess at one.
DEPLOY_URLbecomesSITE_URLin both jobs. It no longer holds what the deployreported, and a name saying otherwise is how the next reader repeats this — the
comment justifying the environment hop claimed the value was "an action output
and so is not ours to trust", which stopped being true with it.
The step comment now records the observed failure mode rather than the guessed
one, with the actual string from
docs-v2026.901.0in it.Scope
Only releases cut from this commit onward are affected — a tag push runs the
workflow as of its own commit.
docs-v2026.901.0's notes have already beencorrected in place with
gh release edit; the site itself was always fine.Checks
actionlint, zizmor,
lint:typos,fmt:checkand the 275 script tests passlocally, and the pre-push hook ran clippy, typecheck and both test suites green.
🤖 Generated with Claude Code