Drop the unused converge-vector evaluator - #1109
Merged
Merged
Conversation
evaluate.ts had no production caller after the forge-read evaluator replaced it, and its check list had already drifted from FORGE_CHECKS. Its only importer was its own test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/loops/factory/evaluate.tsshells out totools/factory/converge-vector.sh, which the forge-read evaluator (forge-evaluate.ts) replaced. Its only importer was its own test, and itsFACTORY_CHECKSlist had already drifted fromFORGE_CHECKS. Found by the whole-branch pre-merge review. Typecheck, knip, and the factory suites are clean without it. Targets the integration branch, notmain.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.