Fix CI by checking out third_party git submodules#5
Merged
Conversation
CMake always add_subdirectory()'s bundled deps under third_party/, but actions/checkout left those directories empty, so configure failed before any tests ran. Also drop the unused /tmp/deps prebuilds — CMAKE_PREFIX_PATH never reached find_package with the current CMakeLists. Co-authored-by: Maksim Zinal <zinal@ydb.tech>
eivanov89
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake always add_subdirectory()'s bundled deps under third_party/, but actions/checkout left those directories empty, so configure failed before any tests ran. Also drop the unused /tmp/deps prebuilds — CMAKE_PREFIX_PATH never reached find_package with the current CMakeLists.