-
Notifications
You must be signed in to change notification settings - Fork 736
New _EnableRuntimeListing config parameter #18968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New _EnableRuntimeListing config parameter #18968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new configuration parameter, _EnableRuntimeListing, to control whether runtime metrics listing is enabled. Key changes include:
- Adding a check in the data source type annotation transformer to validate runtime listing access.
- Declaring and registering the _EnableRuntimeListing parameter in the Solomon config header and source files.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| yql_solomon_datasource_type_ann.cpp | Added runtime listing check and error reporting when disabled. |
| yql_solomon_config.h | Declared the new _EnableRuntimeListing configuration parameter. |
| yql_solomon_config.cpp | Registered the new _EnableRuntimeListing configuration parameter. |
ydb/library/yql/providers/solomon/provider/yql_solomon_datasource_type_ann.cpp
Outdated
Show resolved
Hide resolved
…rce_type_ann.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
🟢 |
|
⚪
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
ydb/library/yql/providers/solomon/provider/yql_solomon_datasource_type_ann.cpp
Outdated
Show resolved
Hide resolved
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Changelog entry
Added new config parameter _EnbaleRuntimeListing, that enables/disables runtime metrics listing.
Changelog category
Description for reviewers
fix for YQ-4326