Skip to content

Conversation

@evanevanevanevannnn
Copy link
Collaborator

Changelog entry

Added new config parameter _EnbaleRuntimeListing, that enables/disables runtime metrics listing.

Changelog category

  • Improvement

Description for reviewers

fix for YQ-4326

@evanevanevanevannnn evanevanevanevannnn requested a review from a team as a code owner May 28, 2025 17:14
@github-actions
Copy link

github-actions bot commented May 28, 2025

2025-05-28 17:15:36 UTC Pre-commit check linux-x86_64-release-asan for 1031850 has started.
2025-05-28 17:15:46 UTC Artifacts will be uploaded here
2025-05-28 17:17:12 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented May 28, 2025

2025-05-28 17:15:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1031850 has started.
2025-05-28 17:15:47 UTC Artifacts will be uploaded here
2025-05-28 17:17:12 UTC Check cancelled

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new configuration parameter, _EnableRuntimeListing, to control whether runtime metrics listing is enabled. Key changes include:

  • Adding a check in the data source type annotation transformer to validate runtime listing access.
  • Declaring and registering the _EnableRuntimeListing parameter in the Solomon config header and source files.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
yql_solomon_datasource_type_ann.cpp Added runtime listing check and error reporting when disabled.
yql_solomon_config.h Declared the new _EnableRuntimeListing configuration parameter.
yql_solomon_config.cpp Registered the new _EnableRuntimeListing configuration parameter.

…rce_type_ann.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented May 28, 2025

2025-05-28 17:18:40 UTC Pre-commit check linux-x86_64-release-asan for affddae has started.
2025-05-28 17:18:51 UTC Artifacts will be uploaded here
2025-05-28 17:21:44 UTC ya make is running...
🟡 2025-05-28 18:54:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13781 13577 0 98 87 19

2025-05-28 18:55:42 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-28 19:29:20 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1562 (only retried tests) 1460 0 67 17 18

2025-05-28 19:29:37 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-28 20:01:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1433 (only retried tests) 1356 0 50 7 20

🟢 2025-05-28 20:01:34 UTC Build successful.
🔴 2025-05-28 20:02:04 UTC ydbd size 3.9 GiB changed* by +6.7 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: affddae diff diff %
ydbd size 4 147 273 176 Bytes 4 154 287 360 Bytes +6.7 MiB +0.169%
ydbd stripped size 1 440 065 016 Bytes 1 442 008 280 Bytes +1.9 MiB +0.135%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 28, 2025

2025-05-28 17:18:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for affddae has started.
2025-05-28 17:18:52 UTC Artifacts will be uploaded here
2025-05-28 17:21:45 UTC ya make is running...
🟡 2025-05-28 18:40:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28787 26086 0 3 2662 36

2025-05-28 18:43:26 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-28 19:24:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
533 (only retried tests) 492 0 4 8 29

2025-05-28 19:24:18 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-05-28 20:06:35 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
323 (only retried tests) 295 0 1 0 27

🟢 2025-05-28 20:06:43 UTC Build successful.
🔴 2025-05-28 20:07:03 UTC ydbd size 2.2 GiB changed* by +3.7 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: affddae diff diff %
ydbd size 2 358 248 400 Bytes 2 362 157 672 Bytes +3.7 MiB +0.166%
ydbd stripped size 495 390 920 Bytes 496 000 168 Bytes +595.0 KiB +0.123%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

🟢 2025-05-28 17:19:38 UTC The validation of the Pull Request description is successful.

@evanevanevanevannnn evanevanevanevannnn added the rebase-and-check Rebase PR with the current base branch and check label May 29, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label May 29, 2025
@github-actions
Copy link

github-actions bot commented May 29, 2025

2025-05-29 10:05:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for d52b49b has started.
2025-05-29 10:05:14 UTC Artifacts will be uploaded here
2025-05-29 10:08:09 UTC ya make is running...
🔴 2025-05-29 11:21:18 UTC ydbd size 2.2 GiB changed* by +4.0 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: d52b49b diff diff %
ydbd size 2 358 248 400 Bytes 2 362 417 704 Bytes +4.0 MiB +0.177%
ydbd stripped size 495 390 920 Bytes 496 025 704 Bytes +619.9 KiB +0.128%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 29, 2025

2025-05-29 10:05:03 UTC Pre-commit check linux-x86_64-release-asan for d52b49b has started.
2025-05-29 10:05:14 UTC Artifacts will be uploaded here
2025-05-29 10:08:08 UTC ya make is running...
🔴 2025-05-29 11:39:06 UTC ydbd size 3.9 GiB changed* by +7.3 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: d52b49b diff diff %
ydbd size 4 147 273 176 Bytes 4 154 924 248 Bytes +7.3 MiB +0.184%
ydbd stripped size 1 440 065 016 Bytes 1 442 220 184 Bytes +2.1 MiB +0.150%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 30, 2025

2025-05-30 09:20:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9ed7455 has started.
2025-05-30 09:21:02 UTC Artifacts will be uploaded here
2025-05-30 09:24:01 UTC ya make is running...
2025-05-30 09:34:45 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented May 30, 2025

2025-05-30 09:20:52 UTC Pre-commit check linux-x86_64-release-asan for 9ed7455 has started.
2025-05-30 09:21:04 UTC Artifacts will be uploaded here
2025-05-30 09:24:09 UTC ya make is running...
2025-05-30 09:34:37 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented May 30, 2025

2025-05-30 09:36:16 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7a01a23 has started.
2025-05-30 09:36:28 UTC Artifacts will be uploaded here
2025-05-30 09:39:20 UTC ya make is running...
🟡 2025-05-30 11:05:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28802 25946 0 6 2575 275

2025-05-30 11:07:46 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-30 11:41:49 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1177 (only retried tests) 911 0 0 0 266

🟢 2025-05-30 11:42:02 UTC Build successful.
🔴 2025-05-30 11:42:20 UTC ydbd size 2.2 GiB changed* by +4.2 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: 7a01a23 diff diff %
ydbd size 2 358 248 400 Bytes 2 362 600 640 Bytes +4.2 MiB +0.185%
ydbd stripped size 495 390 920 Bytes 496 068 456 Bytes +661.7 KiB +0.137%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 30, 2025

2025-05-30 09:36:18 UTC Pre-commit check linux-x86_64-release-asan for 7a01a23 has started.
2025-05-30 09:37:43 UTC Artifacts will be uploaded here
2025-05-30 09:41:26 UTC ya make is running...
🟡 2025-05-30 11:24:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13833 13612 0 118 76 27

2025-05-30 11:25:22 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-30 11:58:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1630 (only retried tests) 1479 0 66 63 22

2025-05-30 11:59:15 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-30 12:32:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1431 (only retried tests) 1351 0 54 7 19

🟢 2025-05-30 12:33:09 UTC Build successful.
🔴 2025-05-30 12:33:43 UTC ydbd size 3.9 GiB changed* by +7.5 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: 7a01a23 diff diff %
ydbd size 4 147 273 176 Bytes 4 155 157 704 Bytes +7.5 MiB +0.190%
ydbd stripped size 1 440 065 016 Bytes 1 442 319 128 Bytes +2.1 MiB +0.157%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@evanevanevanevannnn evanevanevanevannnn merged commit f6552a0 into ydb-platform:main May 30, 2025
12 checks passed
evanevanevanevannnn added a commit to evanevanevanevannnn/ydb that referenced this pull request Jun 2, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
rvu1024 pushed a commit that referenced this pull request Jun 3, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
xyliganSereja pushed a commit to xyliganSereja/ydb_work that referenced this pull request Jun 3, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
evanevanevanevannnn added a commit to evanevanevanevannnn/ydb that referenced this pull request Jun 16, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
evanevanevanevannnn added a commit to evanevanevanevannnn/ydb that referenced this pull request Jun 17, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
evanevanevanevannnn added a commit to evanevanevanevannnn/ydb that referenced this pull request Aug 7, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
evanevanevanevannnn added a commit to evanevanevanevannnn/ydb that referenced this pull request Aug 7, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@liruoko liruoko added the changelog/f25-3 PR участвует в списке изменений label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/f25-3 PR участвует в списке изменений improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants