Skip to content

New _EnableRuntimeListing config parameter #18968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 30, 2025
Merged

New _EnableRuntimeListing config parameter #18968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e435261
new config
evanevanevanevannnn May 28, 2025
412f253
Update ydb/library/yql/providers/solomon/provider/yql_solomon_datasou…
evanevanevanevannnn May 28, 2025
9fdd027
fixed segfault
evanevanevanevannnn May 30, 2025
d97cf1b
fixed issues
evanevanevanevannnn May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ydb/library/yql/providers/solomon/provider/yql_solomon_config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ using namespace NCommon;
TSolomonConfiguration::TSolomonConfiguration()
{
REGISTER_SETTING(*this, _EnableReading);
REGISTER_SETTING(*this, _EnableRuntimeListing);
REGISTER_SETTING(*this, MetricsQueuePageSize);
REGISTER_SETTING(*this, MetricsQueuePrefetchSize);
REGISTER_SETTING(*this, MetricsQueueBatchCountLimit);
Expand Down
1 change: 1 addition & 0 deletions ydb/library/yql/providers/solomon/provider/yql_solomon_config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ struct TSolomonSettings {
#endif
public:
NCommon::TConfSetting<bool, Static> _EnableReading;
NCommon::TConfSetting<bool, Static> _EnableRuntimeListing;
NCommon::TConfSetting<ui64, Static> MetricsQueuePageSize;
NCommon::TConfSetting<ui64, Static> MetricsQueuePrefetchSize;
NCommon::TConfSetting<ui64, Static> MetricsQueueBatchCountLimit;
Expand Down
5 changes: 5 additions & 0 deletions ydb/library/yql/providers/solomon/provider/yql_solomon_datasource_type_ann.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,11 @@ class TSolomonDataSourceTypeAnnotationTransformer : public TVisitorTransformerBa
}
bool hasSelectors = !selectors.Content().empty();

if (hasSelectors && !State_->Configuration->_EnableRuntimeListing.Get().GetOrElse(false)) {
ctx.AddError(TIssue(ctx.GetPosition(selectors.Pos()), "runtime listing is disabled, use `program` parameter"));
return TStatus::Error;
}

auto& program = *input->Child(TSoSourceSettings::idx_Program);
if (!EnsureAtom(program, ctx)) {
return TStatus::Error;
Expand Down
1 change: 1 addition & 0 deletions ydb/library/yql/providers/solomon/provider/yql_solomon_dq_integration.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,7 @@ class TSolomonDqIntegration: public TDqIntegrationBase {

NDq::TDqSolomonReadParams readParams{ .Source = source };

YQL_ENSURE(NActors::TlsActivationContext);
auto metricsQueueActor = NActors::TActivationContext::ActorSystem()->Register(
NDq::CreateSolomonMetricsQueueActor(
std::min<ui64>(maxTasksPerStage, totalMetricsCount),
Expand Down
Loading