Skip to content

Fixed possible crash on creating the transfer (#28895) #28914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2025
Merged

Fixed possible crash on creating the transfer (#28895) #28914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ydb/core/transfer/ut/functional/transfer_ut.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1519,7 +1519,6 @@ Y_UNIT_TEST_SUITE(Transfer)
)");
testCase.CreateTopic(1);

testCase.CreateDirectory("/local/subdir");
testCase.CreateTransfer(TStringBuilder() << "subdir/" << testCase.TransferName, Sprintf(R"(
$l = ($x) -> {
return [
Expand Down
7 changes: 7 additions & 0 deletions ydb/core/tx/schemeshard/schemeshard__op_traits.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,13 @@ struct TSchemeTxTraits<NKikimrSchemeOp::EOperationType::ESchemeOpCreateReplicati
constexpr inline static bool CreateDirsFromName = true;
};

template <>
struct TSchemeTxTraits<NKikimrSchemeOp::EOperationType::ESchemeOpCreateTransfer>
: public TSchemeTxTraitsFallback
{
constexpr inline static bool CreateDirsFromName = true;
};

template <>
struct TSchemeTxTraits<NKikimrSchemeOp::EOperationType::ESchemeOpCreateSecret>
: public TSchemeTxTraitsFallback
Expand Down
18 changes: 15 additions & 3 deletions ydb/core/tx/schemeshard/schemeshard__operation_create_replication.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,17 +543,29 @@ class TCreateReplication: public TSubOperation {

} // anonymous

using TTag = TSchemeTxTraits<NKikimrSchemeOp::EOperationType::ESchemeOpCreateReplication>;
using TReplicationTag = TSchemeTxTraits<NKikimrSchemeOp::EOperationType::ESchemeOpCreateReplication>;
using TTransferTag = TSchemeTxTraits<NKikimrSchemeOp::EOperationType::ESchemeOpCreateTransfer>;

namespace NOperation {

template <>
std::optional<TString> GetTargetName<TTag>(TTag, const TTxTransaction& tx) {
std::optional<TString> GetTargetName<TReplicationTag>(TReplicationTag, const TTxTransaction& tx) {
return tx.GetReplication().GetName();
}

template <>
bool SetName<TTag>(TTag, TTxTransaction& tx, const TString& name) {
bool SetName<TReplicationTag>(TReplicationTag, TTxTransaction& tx, const TString& name) {
tx.MutableReplication()->SetName(name);
return true;
}

template <>
std::optional<TString> GetTargetName<TTransferTag>(TTransferTag, const TTxTransaction& tx) {
return tx.GetReplication().GetName();
}

template <>
bool SetName<TTransferTag>(TTransferTag, TTxTransaction& tx, const TString& name) {
tx.MutableReplication()->SetName(name);
return true;
}
Expand Down
Loading