Skip to content

Conversation

@kardymonds
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@github-actions
Copy link

github-actions bot commented Nov 19, 2025

2025-11-19 08:08:29 UTC Pre-commit check linux-x86_64-release-asan for 901317a has started.
2025-11-19 08:08:46 UTC Artifacts will be uploaded here
2025-11-19 08:10:55 UTC ya make is running...
🟡 2025-11-19 09:25:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11897 11561 0 316 7 13

🟢 2025-11-19 09:26:05 UTC Build successful.
🟢 2025-11-19 09:26:33 UTC ydbd size 3.8 GiB changed* by +6.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3770ba3 merge: 901317a diff diff %
ydbd size 4 096 033 344 Bytes 4 096 040 008 Bytes +6.5 KiB +0.000%
ydbd stripped size 1 520 456 048 Bytes 1 520 458 288 Bytes +2.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

🟢 2025-11-19 08:09:35 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Nov 19, 2025

2025-11-19 08:11:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for 901317a has started.
2025-11-19 08:12:00 UTC Artifacts will be uploaded here
2025-11-19 08:14:06 UTC ya make is running...
🟡 2025-11-19 09:46:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38340 35473 0 1 2839 27

2025-11-19 09:46:54 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-11-19 10:01:22 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60 (only retried tests) 43 0 0 0 17

🟢 2025-11-19 10:01:33 UTC Build successful.
🟢 2025-11-19 10:01:52 UTC ydbd size 2.3 GiB changed* by +5.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3770ba3 merge: 901317a diff diff %
ydbd size 2 446 703 048 Bytes 2 446 708 200 Bytes +5.0 KiB +0.000%
ydbd stripped size 520 128 728 Bytes 520 129 816 Bytes +1.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kardymonds kardymonds marked this pull request as ready for review November 19, 2025 09:30
@kardymonds kardymonds requested a review from a team as a code owner November 19, 2025 09:30
Copilot AI review requested due to automatic review settings November 19, 2025 09:30
Copilot finished reviewing on behalf of kardymonds November 19, 2025 09:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue with precompute functionality by ensuring that result format settings are properly managed per evaluation graph instead of being shared globally. The key change is moving ResultFormatSettings from being a class-level member to being stored within each TEvaluationGraphInfo structure.

  • Added ResultFormatSettings field to TEvaluationGraphInfo struct for per-graph storage
  • Updated PrepareResultFormatSettings to accept a reference parameter instead of using a class member
  • Modified all references to use the appropriate ResultFormatSettings instance (either from graph info or class member)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Nov 19, 2025

2025-11-19 10:50:06 UTC Pre-commit check linux-x86_64-relwithdebinfo for d0432aa has started.
2025-11-19 10:50:23 UTC Artifacts will be uploaded here
2025-11-19 10:52:30 UTC ya make is running...
🟡 2025-11-19 12:15:50 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38347 35481 0 2 2838 26

2025-11-19 12:16:07 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-11-19 12:30:05 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60 (only retried tests) 45 0 1 0 14

2025-11-19 12:30:13 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-11-19 12:38:32 UTC Tests successful.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30 (only retried tests) 16 0 0 0 14

🟢 2025-11-19 12:38:40 UTC Build successful.
🟢 2025-11-19 12:39:02 UTC ydbd size 2.3 GiB changed* by +5.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c05e419 merge: d0432aa diff diff %
ydbd size 2 446 772 256 Bytes 2 446 777 728 Bytes +5.3 KiB +0.000%
ydbd stripped size 520 148 504 Bytes 520 149 656 Bytes +1.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 19, 2025

2025-11-19 10:50:51 UTC Pre-commit check linux-x86_64-release-asan for d0432aa has started.
2025-11-19 10:51:08 UTC Artifacts will be uploaded here
2025-11-19 10:53:16 UTC ya make is running...
🟡 2025-11-19 12:04:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11749 11576 0 152 7 14

🟢 2025-11-19 12:04:49 UTC Build successful.
🟢 2025-11-19 12:05:14 UTC ydbd size 3.8 GiB changed* by +6.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3986e8b merge: d0432aa diff diff %
ydbd size 4 096 192 152 Bytes 4 096 198 808 Bytes +6.5 KiB +0.000%
ydbd stripped size 1 520 505 552 Bytes 1 520 507 792 Bytes +2.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

uzhastik
uzhastik previously approved these changes Nov 19, 2025
@github-actions
Copy link

github-actions bot commented Nov 19, 2025

2025-11-19 14:01:43 UTC Pre-commit check linux-x86_64-release-asan for 88b338b has started.
2025-11-19 14:02:21 UTC Artifacts will be uploaded here
2025-11-19 14:04:15 UTC ya make is running...
🟡 2025-11-19 15:15:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11773 11681 0 73 7 12

🟢 2025-11-19 15:15:46 UTC Build successful.
🟢 2025-11-19 15:16:09 UTC ydbd size 3.8 GiB changed* by +6.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4c15d94 merge: 88b338b diff diff %
ydbd size 4 096 193 400 Bytes 4 096 200 040 Bytes +6.5 KiB +0.000%
ydbd stripped size 1 520 506 064 Bytes 1 520 508 304 Bytes +2.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 19, 2025

2025-11-19 14:02:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for 88b338b has started.
2025-11-19 14:06:07 UTC Artifacts will be uploaded here
2025-11-19 14:08:03 UTC ya make is running...
🟡 2025-11-19 15:34:51 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38374 35505 0 4 2838 27

2025-11-19 15:35:03 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-11-19 15:50:34 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
64 (only retried tests) 47 0 2 0 15

2025-11-19 15:50:40 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-11-19 15:59:29 UTC Some tests failed, follow the links below.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
34 (only retried tests) 20 0 1 0 13

🟢 2025-11-19 15:59:36 UTC Build successful.
🟢 2025-11-19 15:59:59 UTC ydbd size 2.3 GiB changed* by +5.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3986e8b merge: 88b338b diff diff %
ydbd size 2 446 772 656 Bytes 2 446 778 288 Bytes +5.5 KiB +0.000%
ydbd stripped size 520 148 632 Bytes 520 149 784 Bytes +1.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

GrigoriyPA
GrigoriyPA previously approved these changes Nov 19, 2025
@github-actions
Copy link

github-actions bot commented Nov 19, 2025

2025-11-19 20:26:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7fcacc7 has started.
2025-11-19 20:27:00 UTC Artifacts will be uploaded here
2025-11-19 20:29:05 UTC ya make is running...
🟡 2025-11-19 22:10:22 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38379 35512 0 1 2836 30

2025-11-19 22:10:34 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-11-19 22:25:32 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60 (only retried tests) 45 0 0 0 15

🟢 2025-11-19 22:25:39 UTC Build successful.
🟢 2025-11-19 22:25:59 UTC ydbd size 2.3 GiB changed* by +5.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 33c4b00 merge: 7fcacc7 diff diff %
ydbd size 2 448 854 096 Bytes 2 448 859 168 Bytes +5.0 KiB +0.000%
ydbd stripped size 520 529 016 Bytes 520 530 040 Bytes +1.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 19, 2025

2025-11-19 20:28:40 UTC Pre-commit check linux-x86_64-release-asan for 7fcacc7 has started.
2025-11-19 20:28:47 UTC Artifacts will be uploaded here
2025-11-19 20:30:57 UTC ya make is running...
🟡 2025-11-19 22:00:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11741 11600 0 115 13 13

🟢 2025-11-19 22:00:27 UTC Build successful.
🟢 2025-11-19 22:00:54 UTC ydbd size 3.8 GiB changed* by +10.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a007eea merge: 7fcacc7 diff diff %
ydbd size 4 099 598 112 Bytes 4 099 608 872 Bytes +10.5 KiB +0.000%
ydbd stripped size 1 521 776 752 Bytes 1 521 783 088 Bytes +6.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kardymonds kardymonds merged commit 37181a9 into ydb-platform:main Nov 20, 2025
10 checks passed
kardymonds added a commit to kardymonds/ydb that referenced this pull request Nov 20, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
kardymonds added a commit that referenced this pull request Nov 20, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants