Docs and dead-code cleanup for tracegen optimizations#790
Merged
MauroToscano merged 1 commit intoJul 7, 2026
Merged
Conversation
- Reattach the collect_ops_from_cpu doc block to the function (it was landing on struct RegRow together with a stray #[allow]) and update its Returns list to the MemwBuckets shape - Replace references to deleted code and internal review artifacts: the 'Shared by BOTH collectors' rationale (the MemwOperation collector is gone), the E6/E7 notes, and mu_column's 'legacy path' label (update_multiplicities is live for continuation epochs) - Document fill_multiplicities' overwrite semantics: it assumes zeroed MU columns and layered lookups (continuation L2G) must be added strictly after - Remove BitwiseHistogram::total, a pub method with no callers
MauroToscano
force-pushed
the
review/pr786-docs-deadcode
branch
from
a0ba503 to
ae7d5d4
Compare
MauroToscano
merged commit 402952c
into
perf/tracegen-cpu-optimizations
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the #786 review — the quick documentation/dead-code batch (no behavior changes):
collect_ops_from_cpudoc block to the function. It was syntactically attaching tostruct RegRow(together with a stray#[allow(clippy::type_complexity)]), leaving the collector undocumented and RegRow documented as an 11-tuple-returning function. The Returns list now names theMemwBucketsshape.memw_register_is_half_lookup's "Shared by BOTH collectors" rationale (this PR deleted theMemwOperationcollector), the E6/E7 notes, and thecollect_bitwise_from_memw_registermention. The comment now states the invariant that actually matters: the counted lookup must stay in lockstep with the IS_HALFWORD send inmemw_register::bus_interactions().mu_column's "legacy per-op path" label —update_multiplicitiesis live production code (continuation epochs add L2G lookups through it).fill_multiplicities' overwrite semantics: it assumes zeroed MU columns (true for a freshgenerate_bitwise_trace), and layered lookups must be added strictly after the fill.BitwiseHistogram::total— pub method with zero callers, invisible to the dead-code lint.cargo check -p lambda-vm-proverandcargo fmt --checkpass.