ci: improve rust-cache configuration for 100 GB cache limit#4038
Merged
Madoshakalaka merged 1 commit intomasterfrom Mar 3, 2026
Merged
ci: improve rust-cache configuration for 100 GB cache limit#4038Madoshakalaka merged 1 commit intomasterfrom
Madoshakalaka merged 1 commit intomasterfrom
Conversation
Benchmark - coreYew MasterPull Request |
|
Visit the preview URL for this PR (updated for commit ddc3500): https://yew-rs--pr4038-fix-rust-cache-confi-wc1045dl.web.app (expires Tue, 10 Mar 2026 11:46:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Size ComparisonDetails
✅ None of the examples has changed their size significantly. |
Benchmark - SSRYew MasterDetails
Pull RequestDetails
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
shared-keyparameters fromSwatinem/rust-cache, letting each job use the defaultadd-job-id-keyfor per-job cache isolationsave-if: ${{ github.ref == 'refs/heads/master' }}so only master builds save caches (PRs restore from master but don't save)doc_testsandintegration_testssorust-cacheruns after toolchain setup (as required by the action's README)Background
PR #3520 identified that using
shared-keycauses unrelated jobs to share cache entries, leading to suboptimal cache usage. However, the fix was blocked by the 10 GB cache size limit.PR #3711 then intentionally added
shared-keyeverywhere to minimize the number of cache entries, trading cache accuracy for smaller total size.Now that the GitHub Actions cache limit has been raised to 100 GB (thanks to @siku2 ), we can afford per-job caching. This PR revisits the approach from #3520 and goes further: