Skip to content

Check lints also on wasm32 target#4122

Merged
Madoshakalaka merged 3 commits intoyewstack:masterfrom
WorldSEnder:more-lints-on-wasm
Apr 9, 2026
Merged

Check lints also on wasm32 target#4122
Madoshakalaka merged 3 commits intoyewstack:masterfrom
WorldSEnder:more-lints-on-wasm

Conversation

@WorldSEnder
Copy link
Copy Markdown
Member

Description

Fixes #4121

It's not documented, but cargo hack supports a --target flag. Getting the default target is straight forward from rustc --version.

github-actions[bot]
github-actions bot previously approved these changes Apr 8, 2026
github-actions[bot]
github-actions bot previously approved these changes Apr 8, 2026
Copy link
Copy Markdown
Member

@Madoshakalaka Madoshakalaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Nice matrix expansion and case is very cool

@Madoshakalaka Madoshakalaka merged commit b027030 into yewstack:master Apr 9, 2026
7 checks passed
@Madoshakalaka Madoshakalaka added the A-ci Area: The continuous integration label Apr 9, 2026
@WorldSEnder WorldSEnder deleted the more-lints-on-wasm branch April 9, 2026 01:08
@Madoshakalaka
Copy link
Copy Markdown
Member

Madoshakalaka commented Apr 9, 2026

I just noticed none of the cache succefully registered.

image

I looked at Cache metrics and they add up to exactly 10GB

@siku2 maybe the cache limit bump didn't go through?

@Madoshakalaka
Copy link
Copy Markdown
Member

also nice: immediately caught some real issue in #4027

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ci Area: The continuous integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature soundness test should include the wasm32 target too

2 participants