fix: favicons tags

[benlife5]

1. We were injecting an empty favicon tag before the real favicon tag
2. The type was for .ico, but the system sends pngs

This seems to have caused Google to not display the favicon in Google results for some (but not all, not sure why) sites.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7946282a-4385-4417-9c02-78fadea34273

📥 Commits

Reviewing files that changed from the base of the PR and between e1204dc and 6b2106e.

📒 Files selected for processing (3)

• packages/visual-editor/src/vite-plugin/templates/directory.tsx
• packages/visual-editor/src/vite-plugin/templates/locator.tsx
• packages/visual-editor/src/vite-plugin/templates/main.tsx

---

Walkthrough

The change modifies the getHeadConfig function in three template files (directory.tsx, locator.tsx, main.tsx). In each file, a duplicate favicon <link rel="icon"> entry previously using type: "image/x-icon" is removed from the tags array, and the remaining conditional favicon link's type attribute is updated from image/x-icon to image/png.

Changes

File	Change
directory.tsx	Removed duplicate favicon entry; updated remaining favicon type to image/png
locator.tsx	Removed duplicate favicon entry; updated remaining favicon type to image/png
main.tsx	Removed duplicate favicon entry; updated remaining favicon type to image/png

Suggested reviewers: mkilpatrick, briantstephan

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and matches the main change: fixing favicon tag handling.
Description check	✅ Passed	The description accurately describes the favicon tag and MIME type fixes in the change set.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch main-favicon

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[jhelenek]

👍