Skip to content

feat: add image styling props for expanded header and footer images - #1282

Merged
nanhu95 merged 4 commits into
mainfrom
fix-header-footer-image-styling
Aug 6, 2026
Merged

feat: add image styling props for expanded header and footer images#1282
nanhu95 merged 4 commits into
mainfrom
fix-header-footer-image-styling

Conversation

@nanhu95

@nanhu95 nanhu95 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Add image styling props (fit or fill) for the images that can be used in the expanded header or footer.

Screen.Recording.2026-08-05.at.14.41.03.mov

Add image styling props (fit or fill) for the images
that can be used in the expanded header or footer.
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 502b5423-6b7d-4f7a-8548-6caf925f2cc6

📥 Commits

Reviewing files that changed from the base of the PR and between 4480258 and 7fbf20b.

⛔ Files ignored due to path filters (1)
  • packages/visual-editor/src/components/testing/screenshots/PhotoGallerySection/[desktop] version 59 with showSectionHeading false.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
📒 Files selected for processing (3)
  • packages/visual-editor/src/components/footer/FooterLogoSlot.tsx
  • packages/visual-editor/src/components/footer/FooterUtilityImagesSlot.tsx
  • packages/visual-editor/src/docs/components.md
🚧 Files skipped from review as they are similar to previous changes (3)
  • packages/visual-editor/src/components/footer/FooterLogoSlot.tsx
  • packages/visual-editor/src/docs/components.md
  • packages/visual-editor/src/components/footer/FooterUtilityImagesSlot.tsx

Walkthrough

The change adds configurable image fill behavior to footer logo and utility image slots. The Image component maps "fit" to contain and other fill types to cover for both rendering paths. Footer slot configuration, defaults, and documentation now expose imageFillType. A registered migration sets missing values to "fill" while preserving existing styles and configured values.

Possibly related PRs

Suggested reviewers: jwartofsky-yext, benlife5

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes adding image styling props for expanded header and footer images.
Description check ✅ Passed The description directly explains the addition of fit or fill image styling props for expanded headers and footers.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-header-footer-image-styling

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread packages/visual-editor/src/utils/migrate.test.ts Outdated

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/visual-editor/src/docs/components.md`:
- Line 379: Update the `styles.imageFillType` API reference rows in
`components.md` to show `fill` in the `Default` column, including both
occurrences identified in the comment, so omitted values match the footer slot
configuration default.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5714355e-bd50-4ea3-93e7-4a919b194451

📥 Commits

Reviewing files that changed from the base of the PR and between 5574293 and 4480258.

📒 Files selected for processing (1)
  • packages/visual-editor/src/docs/components.md

Comment thread packages/visual-editor/src/docs/components.md Outdated
@nanhu95
nanhu95 requested a review from asanehisa August 6, 2026 17:26

@benlife5 benlife5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actions has an active incident

@nanhu95
nanhu95 merged commit 763b8ea into main Aug 6, 2026
5 of 15 checks passed
@nanhu95
nanhu95 deleted the fix-header-footer-image-styling branch August 6, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants