skip invalid fields in write_headers to prevent response splitting#2505
Merged
Conversation
Owner
|
@metsw24-max thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server serialises
res.headersstraight throughwrite_headers, which formats each entry asname: valuefollowed by CRLF without checking either part. The client side already guards this:req.headersgo throughcheck_and_write_headers, and the request line and websocket handshake run the sameis_field_valuecheck, sowrite_headerswas the one output path left unguarded.Response::headersis a public field, and an application that reflects a request-derived value into it (a fairly common pattern) can carry a CR/LF into the response, splitting the header block and injecting further headers or a body. I noticed the gap while reading the recent chunked-trailer fix, which closed the same class for trailers but did not reach the ordinary header writer. The change skips any field whose name or value fails validation, which keeps the behaviour consistent withset_headerrather than dropping the whole response. Fields the library emits itself all go throughset_headerand stay valid, so only directly-injected ones are affected. The regression test drives a handler that plants CR/LF in both a header name and value viares.headersand checks the split content never reaches the wire.