Skip to content

register the backend handler before starting the proxy#122

Merged
yihui merged 5 commits into
yihui:mainfrom
remlapmot:fix-shquotes
Jun 19, 2026
Merged

register the backend handler before starting the proxy#122
yihui merged 5 commits into
yihui:mainfrom
remlapmot:fix-shquotes

Conversation

@remlapmot

@remlapmot remlapmot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

fixes flaky httpd tests

@yihui yihui changed the title Fix system3() to not shQuote() args passed to system2() register the backend handler before starting the proxy Jun 19, 2026

@yihui yihui left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed the blogdown issue separately in blogdown, and a new release is on its way to CRAN. For xfun, actually I've been puzzled by the flaky tests here for a long time. Thank you so much for figuring this out!

@yihui
yihui merged commit ca14445 into yihui:main Jun 19, 2026
10 checks passed
@remlapmot

Copy link
Copy Markdown
Contributor Author

My pleasure Yihui.

Also I meant to add - while running the httpd tests I think I noticed that new_app(name = '') can leave its reverse-proxy process running in the background. Obvs this doesn't matter in CI but annoying on your dev machine.

@yihui

yihui commented Jun 22, 2026

Copy link
Copy Markdown
Owner

@remlapmot Good catch. acbe9b3 should terminate the background process now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants