Fix nightly installation on Windows - #149
Conversation
|
Warning Review limit reached
Next review available in: 40 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe Windows installer now resolves ChangesWindows nightly installation
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant User
participant WindowsInstaller
participant GitHubReleases
User->>WindowsInstaller: Request version nightly
WindowsInstaller->>GitHubReleases: Search up to ten release pages
GitHubReleases-->>WindowsInstaller: Return prerelease tags
WindowsInstaller->>WindowsInstaller: Select matching nightly tag
WindowsInstaller-->>User: Download resolved version or report unavailable release
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the Windows PowerShell installer to correctly resolve YIIPRESS_VERSION=nightly by discovering the newest immutable nightly prerelease tag via the GitHub Releases API, aligning its behavior with the existing shell installer, and documenting the PowerShell nightly flow.
Changes:
- Add nightly prerelease discovery (paginated GitHub Releases API lookup) to
install.ps1. - Extend the installer unit test to assert the PowerShell script includes the nightly-resolution logic.
- Document PowerShell nightly installation and clarify nightly tag/page-scanning behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/Unit/Packaging/InstallerTest.php | Adds assertions to ensure the PowerShell installer includes nightly-resolution logic. |
| install.ps1 | Implements nightly tag discovery via GitHub prereleases with pagination. |
| docs/binaries-phar-docker.md | Documents PowerShell nightly installation and clarifies nightly resolution rules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/Unit/Packaging/InstallerTest.php (1)
259-267: 📐 Maintainability & Code Quality | 🔵 Trivial | 🏗️ Heavy liftAdd an executable test for the PowerShell nightly path.
These assertions only check literal text in
install.ps1. The nightly behavior tests executeinstall.shthroughrunInstaller(), so they cannot detect regressions in PowerShell release parsing or pagination. Add PHPUnit coverage that invokesinstall.ps1under Windows PowerShell or PowerShell 7 with controlled release responses.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/Unit/Packaging/InstallerTest.php` around lines 259 - 267, Add executable PHPUnit coverage for the PowerShell nightly path in the installer tests, alongside the existing assertions in the relevant test class. Invoke install.ps1 through the available Windows PowerShell or PowerShell 7 executable, stub controlled GitHub release responses, and verify nightly release parsing and pagination behavior, including the no-release failure case.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/Unit/Packaging/InstallerTest.php`:
- Around line 259-267: Add executable PHPUnit coverage for the PowerShell
nightly path in the installer tests, alongside the existing assertions in the
relevant test class. Invoke install.ps1 through the available Windows PowerShell
or PowerShell 7 executable, stub controlled GitHub release responses, and verify
nightly release parsing and pagination behavior, including the no-release
failure case.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: d028b307-a6cb-4dbb-afeb-b6ba7657178f
📒 Files selected for processing (3)
docs/binaries-phar-docker.mdinstall.ps1tests/Unit/Packaging/InstallerTest.php
Summary
YIIPRESS_VERSION=nightlythrough GitHub prereleases in the PowerShell installerTests
make test CLI_ARGS='tests/Unit/Packaging/InstallerTest.php'(10 tests, 155 assertions)Summary by CodeRabbit
New Features
Bug Fixes