Skip to content

Fix #97: Add macOS binary tests to CI - #98

Merged
samdark merged 2 commits into
masterfrom
issue-97-macos-binary-tests
Jul 10, 2026
Merged

Fix #97: Add macOS binary tests to CI#98
samdark merged 2 commits into
masterfrom
issue-97-macos-binary-tests

Conversation

@samdark

@samdark samdark commented Jul 10, 2026

Copy link
Copy Markdown
Member

Closes #97

Summary

  • build the native arm64 macOS binary in the test workflow
  • exercise init, content creation, build, link checking, output verification, and clean with the packaged executable
  • document the platform binary coverage and mark the roadmap item complete

Testing

  • git diff --check
  • make test (cannot run locally: Docker daemon is unavailable)

Summary by CodeRabbit

  • Tests

    • Added automated macOS binary testing to the CI workflow.
    • macOS packaged binaries now undergo end-to-end checks, including site creation, building, link validation, output verification, and cleanup.
    • Continued coverage for native Windows and macOS executable workflows.
  • Documentation

    • Updated workflow documentation to describe Windows and macOS binary testing.
    • Added the macOS binary test pipeline to the completed developer experience roadmap.

Copilot AI review requested due to automatic review settings July 10, 2026 10:44
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@samdark, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 17 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 891969ae-f990-4687-b9bb-489a5c520b4e

📥 Commits

Reviewing files that changed from the base of the PR and between c745c9b and a61f212.

📒 Files selected for processing (4)
  • .github/workflows/run-tests.yml
  • docs/binaries-phar-docker.md
  • roadmap.md
  • tests/Unit/Packaging/ConfigurationPackagingTest.php
📝 Walkthrough

Walkthrough

Adds a macOS GitHub Actions job that builds and tests the packaged binary through a complete site lifecycle, and updates workflow documentation and the developer-experience roadmap.

Changes

macOS Binary Validation

Layer / File(s) Summary
macOS packaged executable CI lifecycle
.github/workflows/run-tests.yml, docs/binaries-phar-docker.md, roadmap.md
The workflow installs PHP, Rust, and Homebrew dependencies, builds the macOS binary, runs site lifecycle assertions, and documents and tracks the new CI coverage.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

  • yiipress/engine#36: Adds the macOS static build script and packaging target used by this CI job.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding macOS binary tests to CI.
Linked Issues check ✅ Passed The PR adds macOS executable testing in CI, matching issue #97's request to test the binary like Windows.
Out of Scope Changes check ✅ Passed The docs and roadmap edits support the macOS binary test work and do not introduce unrelated scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-97-macos-binary-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds macOS (arm64) packaged-binary coverage to the CI “Run Tests” workflow, mirroring the existing Windows executable smoke/lifecycle checks, and documents/marks completion of the roadmap item for platform-binary CI coverage.

Changes:

  • Extend Run Tests GitHub Actions workflow with a macos-14 job that builds the arm64 macOS binary and exercises an end-to-end site lifecycle using the packaged executable.
  • Update binary coverage documentation to reflect that both Windows and macOS binaries are exercised in CI.
  • Mark the “macOS binary test pipeline in CI” roadmap item as completed.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
roadmap.md Marks macOS binary CI testing as completed.
docs/binaries-phar-docker.md Updates documentation to describe macOS + Windows binary testing in CI.
.github/workflows/run-tests.yml Adds a macOS arm64 binary build + lifecycle test job to the test workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/run-tests.yml

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/binaries-phar-docker.md`:
- Line 47: The documentation incorrectly implies that PHPUnit runs before the
Windows and macOS builds, although the test, windows, and macos jobs execute
concurrently. Update the “Run Tests” workflow description to use parallel
wording such as “runs PHPUnit … and builds …,” while preserving the existing
lifecycle details.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fcc4796a-d6d4-43c0-a267-c41fc08b766e

📥 Commits

Reviewing files that changed from the base of the PR and between 41cd5dd and c745c9b.

📒 Files selected for processing (3)
  • .github/workflows/run-tests.yml
  • docs/binaries-phar-docker.md
  • roadmap.md

Comment thread docs/binaries-phar-docker.md Outdated
@samdark
samdark force-pushed the issue-97-macos-binary-tests branch from c745c9b to 6ab4839 Compare July 10, 2026 10:49
@samdark samdark changed the title Add macOS binary tests to CI Fix #97: Add macOS binary tests to CI Jul 10, 2026
@samdark
samdark merged commit 425f38d into master Jul 10, 2026
9 checks passed
@samdark
samdark deleted the issue-97-macos-binary-tests branch July 10, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test MacOS binary as executable same way as Windows one

2 participants