Fix #97: Add macOS binary tests to CI - #98
Conversation
|
Warning Review limit reached
Next review available in: 17 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughAdds a macOS GitHub Actions job that builds and tests the packaged binary through a complete site lifecycle, and updates workflow documentation and the developer-experience roadmap. ChangesmacOS Binary Validation
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds macOS (arm64) packaged-binary coverage to the CI “Run Tests” workflow, mirroring the existing Windows executable smoke/lifecycle checks, and documents/marks completion of the roadmap item for platform-binary CI coverage.
Changes:
- Extend
Run TestsGitHub Actions workflow with amacos-14job that builds the arm64 macOS binary and exercises an end-to-end site lifecycle using the packaged executable. - Update binary coverage documentation to reflect that both Windows and macOS binaries are exercised in CI.
- Mark the “macOS binary test pipeline in CI” roadmap item as completed.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
roadmap.md |
Marks macOS binary CI testing as completed. |
docs/binaries-phar-docker.md |
Updates documentation to describe macOS + Windows binary testing in CI. |
.github/workflows/run-tests.yml |
Adds a macOS arm64 binary build + lifecycle test job to the test workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/binaries-phar-docker.md`:
- Line 47: The documentation incorrectly implies that PHPUnit runs before the
Windows and macOS builds, although the test, windows, and macos jobs execute
concurrently. Update the “Run Tests” workflow description to use parallel
wording such as “runs PHPUnit … and builds …,” while preserving the existing
lifecycle details.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: fcc4796a-d6d4-43c0-a267-c41fc08b766e
📒 Files selected for processing (3)
.github/workflows/run-tests.ymldocs/binaries-phar-docker.mdroadmap.md
c745c9b to
6ab4839
Compare
Closes #97
Summary
Testing
git diff --checkmake test(cannot run locally: Docker daemon is unavailable)Summary by CodeRabbit
Tests
Documentation