Skip to content

Fix #124: Fix HttpBasic and HttpBearer to add WWW-Authenticate header instead of overwriting it - #125

Merged
samdark merged 2 commits into
masterfrom
fix-composite
Aug 9, 2026
Merged

Fix #124: Fix HttpBasic and HttpBearer to add WWW-Authenticate header instead of overwriting it#125
samdark merged 2 commits into
masterfrom
fix-composite

Conversation

@vjik

@vjik vjik commented Aug 7, 2026

Copy link
Copy Markdown
Member
Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fix #124

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0fcf73c9-f231-4a4f-b9ae-f4d6123e1eee

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.97%. Comparing base (8c7abac) to head (19f1489).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #125   +/-   ##
=========================================
  Coverage     95.97%   95.97%           
  Complexity       80       80           
=========================================
  Files            10       10           
  Lines           199      199           
=========================================
  Hits            191      191           
  Misses            8        8           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vjik
vjik requested a review from a team August 7, 2026 06:44
@vjik vjik added the status:code review The pull request needs review. label Aug 7, 2026
@samdark samdark changed the title Fix HttpBasic and HttpBearer to add WWW-Authenticate header instead of overwriting it Fix #124: Fix HttpBasic and HttpBearer to add WWW-Authenticate header instead of overwriting it Aug 9, 2026
@samdark
samdark merged commit 1addab2 into master Aug 9, 2026
29 checks passed
@samdark

samdark commented Aug 9, 2026

Copy link
Copy Markdown
Member

👍

@samdark
samdark deleted the fix-composite branch August 9, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Composite::challenge() overwrites WWW-Authenticate headers instead of accumulating them

2 participants