Skip to content

Remove Codecov failure override - #810

Merged
vjik merged 1 commit into
masterfrom
remove-codecov-fail-ci-option
Jul 13, 2026
Merged

Remove Codecov failure override#810
vjik merged 1 commit into
masterfrom
remove-codecov-fail-ci-option

Conversation

@samdark

@samdark samdark commented Jul 13, 2026

Copy link
Copy Markdown
Member

Removes the explicit codecovFailCiIfError override from the PHPUnit workflow so the shared workflow default is used. Validation: git diff --check.

Copilot AI review requested due to automatic review settings July 13, 2026 07:27
@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.29%. Comparing base (7e4fabc) to head (0ab58c9).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #810   +/-   ##
=========================================
  Coverage     96.29%   96.29%           
  Complexity     1154     1154           
=========================================
  Files           124      124           
  Lines          3540     3540           
=========================================
  Hits           3409     3409           
  Misses          131      131           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the explicit codecovFailCiIfError: false override from the GitHub Actions PHPUnit workflow jobs so that the default behavior from the shared yiisoft/actions reusable workflow is applied.

Changes:

  • Removed codecovFailCiIfError: false from the phpunit job inputs.
  • Removed codecovFailCiIfError: false from the phpunit-without-intl job inputs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vjik
vjik merged commit 3a33f43 into master Jul 13, 2026
40 checks passed
@vjik
vjik deleted the remove-codecov-fail-ci-option branch July 13, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants