It should be negative?

[marsuboss]

No description provided.

[qiangxue]

This is currency formatting. Negative values may be formatted using parenthesis.

[marsuboss]

So why in my test, i have a message error :

There was 1 failure:

1) yiiunit\framework\i18n\FormatterTest::testAsCurrency
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-($123,456.12)
+-$123,456.12

[qiangxue]

I guess it's because you don't have intl PHP extension installed.

[cebe]

This is different depended on ICU version...
Please show yours:

echo PHP_VERSION . "\n";
echo INTL_ICU_VERSION . "\n";

[marsuboss]

No i confirm that the extension installed. (All tests i18n passed except one : negative)

PHP_VERSION : 5.5.3
ICU_VERSION : 52.1

[coveralls]

Coverage remained the same when pulling 754c66f on marsuboss:patch-1 into f5219d2 on yiisoft:master.

[cebe]

Yeah ICU formatting changed somewhere between versions 52 and 4.8. Currently we run unit tests on travis against 4.8 afaik.

[coveralls]

Coverage remained the same when pulling 754c66f on marsuboss:patch-1 into f5219d2 on yiisoft:master.

[samdark]

@cebe do you plan correcting tests or doing something else?

[cebe]

Not sure what to do yet. looks like we have to add a switch in the test that depends on ICU verison