Added BatchInsert trait for MySQL, CUBRID, PostreSQL, MSSQL #1307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Added it for PostgreSQL as well, since multiple rows insertion support was added for years. I am wondering if we should add it for sqlite as well since it is support since http://sqlite.org/releaselog/3_7_11.html - relatively recent. (thanks to @nineinchnick for pointing that out on #yii) |
Contributor
Author
|
IMHO, let's not add this Trait for sqlite, as in most environments in my experience <=3.6.20 is used still. I am done with this PR, feel free to merge. |
Member
|
Instead of using trait, I moved batchInsert to base class. If a child class doesn't support this, it can simply throw NotSupportedException. |
cebe
added a commit
that referenced
this pull request
Nov 24, 2013
* master: Fixes #1253 Fixes #1310: ActiveRelation does not preserve order of items on find via() and viaTable() fixed limit/offset for sqlite,mysql and cubrid fixed test break. Fixed test break. Fixes #1301: fixed scenario generation when there are "except" scenarios. support for batch insert in sqlite older than 3.7.11 Fixes #1298: supporting route with trailing slash. Fixes #1296: stricter check of dashes in route. Fixes #1307: move batchInsert() to base class. Update apps-advanced.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed duplicate code that provides
batchInsert()for MySQL, CUBRID, PostreSQL, SQL Server