fix(da): restore lowercase dotted abbreviation boundaries - #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
s.u./s.U.to be under-segmented before capitalized followers.Description
SENTENCE_BOUNDARY_ABBREVIATIONSattribute toAbbreviationReplacerso languages can list multi-period abbreviations that should be treated as sentence-boundary candidates.replace_multi_period_abbreviations()computeabbreviation_key = matched[:-1].lower()and uselisted_sentence_boundaryto influence the final-period restoration decision (treat listed entries as split candidates before likely sentence starts).AbbreviationReplacerto includeSENTENCE_BOUNDARY_ABBREVIATIONS = frozenset({"s.u"})sos.u.ands.U.split correctly before a capitalized follower.Testing
uv run pytest tests/regression/test_segment_snapshot.py tests/unit/test_abbreviation_replacer.py tests/regression/test_greek_abbreviations.py tests/lang/test_danish.pyand all collected tests passed.uv run python -m tests.regression.segment_snapshot --updateand verified the snapshot-based regression testtests/regression/test_segment_snapshot.pypassed after the update.uv run pytest --cov=sentencesplit tests/ --color yesand observed the test suite completed with the expected pass/skip/xfail summary and coverage threshold met.Codex Task