Conversation
- Remove phpmd: overlaps PHPStan/CS-Fixer, lenient thresholds, mostly excluded rules — low value. Drop phpmd/phpmd, phpmd.xml, the pre-push checklist step, and the five @SuppressWarnings(PHPMD.*) annotations. - Untrack CLAUDE.md (local AI-tooling config): gitignore it and remove from the repo; the file is kept locally. Co-Authored-By: Claude <noreply@anthropic.com>
Add two integration tests asserting the orphaned new backing index is deleted when rebuild fails: - import source throws mid-import - alias swap fails because the name is a real index (not an alias) These exercise the two try/catch cleanup paths in Rebuild::doRun() that had no coverage. Co-Authored-By: Claude <noreply@anthropic.com>
Close the gap flagged before a stable release: Span and Shape queries had
only unit DSL tests, which can't catch a self-consistent-but-wrong shape
(the SpanTerm {term} bug was exactly that — its unit test asserted the
wrong key and passed).
- SpanContractTest: span_term / span_near / span_or against the shared
seeded index's content field.
- ShapeContractTest: the cartesian `shape` query needs a `shape`-typed
field, so each test builds a dedicated index with two disjoint envelopes
and exercises INTERSECTS / DISJOINT.
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…/scroll paths
- Doc::refresh() accepts bool (true/false) alongside string ('wait_for'),
matching ES refresh; the string-only type rejected refresh(true) despite
the PHPDoc advertising true/false.
- docs: swapAlias($alias, $fromIndex) in EN/ZH cheat sheets (was $target;
named-arg form would fatal).
- tests: cover Bulk::flush() default-error throw, strengthen scroll (exact
count + clear) and add scroll->next->clear, lock refresh(bool).
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First stable release. Promotes 8.0.0 out of beta and freezes the public API: public method parameter names are part of the API (named arguments are supported) and
will not change in 8.x patch/minor releases.
Merges all
devcommits since8.0.0-beta.5intomasterand publishes8.0.0.Commits in this PR
docs(changelog): 8.0.0— the GA entry + API-freeze declarationfix(index): widen Doc::refresh to bool, fix swapAlias doc, cover bulk/scroll pathsDoc::refresh()acceptsbool(true/false) alongsidestring('wait_for'), matching ESrefresh. The oldstring-only type rejectedrefresh(true)witha
TypeErrordespite the PHPDoc advertisingtrue/false.swapAlias($alias, $fromIndex)in EN/ZH cheat sheets (was$target— named-arg form would fatal).Bulk::flush()default-error throw (noonErrorhandler), strengthenedscroll()(exact hit count + explicitclear()), addedscroll -> next -> clear,locked
refresh(bool)against regression.test(dsl): add Span/Shape integration contractstest(index): cover Rebuild import/swap failure cleanupdocs: drop the long-lived processes sectionchore: drop phpmd and stop tracking CLAUDE.mdVerification
All gates green locally (Docker, ES 8.15):
CI runs the same suite across PHP 8.1/8.2/8.3 + integration on ES 8.17.