Persist plugin thread status and repair Darwin plugin builds - #917
Conversation
…thr_pv8x7wzi7q # Conflicts: # docs/api_to_audit.md # packages/plugin-sdk/bundled-types/bb-plugin-sdk.d.ts # packages/templates/src/generated/plugin-sdk-dts.generated.ts
…thr_pv8x7wzi7q # Conflicts: # packages/templates/src/generated/plugin-sdk-dts.generated.ts
SawyerHood
left a comment
There was a problem hiding this comment.
🚨 SLOP COP 🚨 · review
I am SlopCop. I started the review under the supplied security, code quality, performance, and end-to-end test rules.
SawyerHood
left a comment
There was a problem hiding this comment.
🚨 SLOP COP 🚨 · review
Security review complete. I found no actionable security issue. The new setter accepts any thread ID, but content scripts already run as trusted same-origin code.
SawyerHood
left a comment
There was a problem hiding this comment.
🚨 SLOP COP 🚨 · review
Code quality review complete. I found no actionable correctness or contract issue. The lifecycle, status ownership, UI priority, SDK declarations, and Darwin package checks are consistent.
SawyerHood
left a comment
There was a problem hiding this comment.
🚨 SLOP COP 🚨 · review
Performance review complete. I posted two findings: a workspace-wide dual-CPU install cost and three full package-tree scans during packaging.
SawyerHood
left a comment
There was a problem hiding this comment.
🚨 SLOP COP 🚨 · review
Test phase complete. Turbo type checks passed for @bb/app, @bb/plugin-sdk, and @bb/desktop. Turbo tests passed with 297 app files and 2,191 app tests, plus the plugin SDK and desktop suites. I started the exact PR head and opened it with a browser. The app shell loaded without page or console errors. The isolated test data had no installed status plugin, so the automated lifecycle and route-status tests provide the status-specific coverage.
SawyerHood
left a comment
There was a problem hiding this comment.
🚨 SLOP COP 🚨 · review
Review complete. I found no security or correctness issue. I found two non-blocking performance issues: normal installs now fetch both CPU variants, and desktop packaging scans the full output tree three times.
Validation passed: all affected type checks, all affected package tests, and a browser smoke test at the exact head SHA.
SawyerHood
left a comment
There was a problem hiding this comment.
Please delete the old plugin api that you added previously (the one to set a thread status via useComposer)
|
Addressed the requested API deletion in 658d131: removed |
Summary
Verification
@bb/app,@bb/desktop,@bb/plugin-sdk, and@bb/templatesDependency
Merge this host capability before brsbl/bb-plugins#12. The Prompt Improver plugin feature-detects the API, so this order is backward-safe and avoids shipping the plugin with its persistent indicator dormant.