ci: add missing test_site_reference_snapshot.py to a pytest shard#166
Open
rizumita wants to merge 1 commit into
Open
ci: add missing test_site_reference_snapshot.py to a pytest shard#166rizumita wants to merge 1 commit into
rizumita wants to merge 1 commit into
Conversation
The 3-way shard split (#164) omitted tests/test_site_reference_snapshot.py from every shard-N.txt, so the new "shard coverage check" job fails on every PR against main regardless of what the PR touches. Add it to shard-1 (it's a fast file-diff test, so shard balance is unaffected).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci: split pr-full pytest run into 3 balanced shards) omittedtests/test_site_reference_snapshot.pyfrom.github/ci-shards/shard-*.txt.shard coverage checkjob (.github/workflows/*.yml,pr-shard-coverage) diffs the union of the shard files againsttests/test_*.pyand fails if they don't match exactly — so this currently fails on every PR againstmain, independent of what the PR changes. Discovered while investigating an unrelated docs PR (docs(site): deepen the fsl-domain and fsl-ai manual pages #165) whose only failing check was this one.Changes
.github/ci-shards/shard-1.txt— addtests/test_site_reference_snapshot.py(alphabetically placed). It's a fast file-diff/freshness test (~0.1s), so it doesn't materially change shard-1's runtime balance.Verification
Risk / Review Notes
Follow-Up / Post-Merge Checks