Drop unneeded issues: write permission from publish workflow#95
Merged
Conversation
Commenting on a PR via the issues.createComment API keys its permission off the target resource, so pull-requests: write covers it. Mirrors the same cleanup made in ynab-sdk-python#31.
bradymholt
changed the title
issues: write permission from publish workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to dbertram's feedback on ynab-sdk-python#31. While reviewing the Python publish workflow we confirmed that
issues: writeisn't needed for the "comment on released PRs" step:issues.createCommentkeys its permission off the target resource, so commenting on a PR is covered bypull-requests: writealone. We never comment on a real issue in this workflow.This makes the same cleanup here in the Ruby SDK's publish workflow: drops
issues: writeand annotatespull-requests: writewith why it's needed, matching ynab-sdk-python.