Chore: Use new editorial families - #142
Open
iLLiCiTiT wants to merge 3 commits into
Open
Conversation
iLLiCiTiT
added
the
type: enhancement
4 tasks
rdelillo
approved these changes
Jul 21, 2026
rdelillo
left a comment
rdelillo
left a comment
Contributor
There was a problem hiding this comment.
Tested with develop core and ynput/ayon-core#1967 (review), works as expected.
|
|
||
| if review_switch is True: | ||
| if reviewable_source == "clip_media": | ||
| instance.data["families"].append("review") |
Contributor
There was a problem hiding this comment.
Suggested change
| instance.data["families"].append("otio.review.clip") |
This'll need to be adjusted if we decide to change:
ynput/ayon-core#1967 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Use new families defined in core to process editorial instances.
Additional review information
This PR in ayon core is adding new families that are used to explicitly process instances instead of host based processing.
This PR is adding the families but should still work with old core. The same the core PR should work with hiero develop.
Testing notes:
All possible combinations of ayon-core and ayon-hiero should produce exactly same output.