refactor: improve code a lot#13
Merged
yoannfleurydev merged 4 commits intomasterfrom Oct 5, 2020
Merged
Conversation
Owner
yoannfleurydev
commented
Aug 13, 2020
yoannfleurydev
commented
- no more custom logger
- no more env var custom code
- better module management
ilaborie
reviewed
Aug 14, 2020
yoannfleurydev
force-pushed
the
refactor-after-workshop
branch
from
56c0178 to
65507f5
Compare
yoannfleurydev
force-pushed
the
refactor-after-workshop
branch
from
c5084a1 to
3b261f7
Compare
- no more custom logger - no more env var custom code - better module management
thanks to @ilaborie for the review, it helped me a lot to learn more about rust
yoannfleurydev
force-pushed
the
refactor-after-workshop
branch
from
65c0419 to
784578c
Compare
yoannfleurydev
force-pushed
the
refactor-after-workshop
branch
from
784578c to
078daf6
Compare
closes #17
yoannfleurydev
force-pushed
the
refactor-after-workshop
branch
from
49e057d to
73cb420
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.