ci: bump the gasp conformance pin to the lenient checker - #169
Merged
Conversation
The pin sat at 08a60a2, which predates today's fix, so this job was still certifying yoagent against the 0.4-era strict fold: one dangling op aborted check 2 and the run reported a failure with no indication of which op or how many others would have folded fine. 795bb93 folds leniently and names what it skipped on the certificate, and also drops the build.rs whose Cargo.lock parsing printed "unknown" for exactly the kind of build CI does. Verified by running the job's own sequence locally against the new SHA before bumping — emit, clone, check — rather than finding out on main: 7/7 with no skips, since yoagent's emitted repo has no dangling ops. The lenient fold changes what happens when one appears; it does not lower the bar for a clean store. Records the bump protocol in the comment, since the previous one said only "pin" without saying what makes a bump safe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pin sat at
08a60a2— before today's fix — so this job was still certifying yoagent against the 0.4-era strict fold, where one dangling op aborts check 2 and the run reports a failure without saying which op, or how many others would have folded fine.795bb93folds leniently (gasp#3) and names what it skipped on the certificate. It also drops thebuild.rs(gasp#4) whoseCargo.lockparsing printedunknownfor exactly the kind of build CI does.Verified before bumping, not after
Ran this job's own sequence locally against the new SHA — emit, clone, check:
7/7 with no skip notes — yoagent's emitted repo has no dangling ops. The lenient fold changes what happens when one appears; it does not lower the bar for a clean store. (The real
yoyo-gaspstore, 8.8K events, does have one, and now reports it as a note rather than a hard failure.)The comment now records what makes a bump safe, since the old one said only "pin".
🤖 Generated with Claude Code