UCP/EP/FLUSH: fix error handling flow#91
Merged
yosefe merged 1 commit intoyosefe:integration3from Nov 17, 2020
Merged
Conversation
Collaborator
Author
|
@yosefe pls take a look |
yosefe
reviewed
Nov 16, 2020
| ucs_assert(ep->flags & UCP_EP_FLAG_FAILED); | ||
| if (req->send.state.uct_comp.count > 0) { | ||
| destroyed_lanes = req->send.flush.started_lanes & ~all_lanes; | ||
| req->send.flush.started_lanes &= ~destroyed_lanes; |
Collaborator
Author
There was a problem hiding this comment.
anyway need to calculate destroyed_lanes for counter update, so IMO ~destroyed_lanes looks clearer - aligned with comment above and counter update
| if (req->send.state.uct_comp.count > 0) { | ||
| destroyed_lanes = req->send.flush.started_lanes & ~all_lanes; | ||
| req->send.flush.started_lanes &= ~destroyed_lanes; | ||
| req->send.state.uct_comp.count -= ucs_popcount(destroyed_lanes); |
Owner
There was a problem hiding this comment.
align on =
add ucs_debug that "req %p: lanes 0x%x were destroyed so reducing comp count by %d"
Collaborator
Author
There was a problem hiding this comment.
align on =
lines becomes too long, separated with ucs_debug
evgeny-leksikov
force-pushed
the
integration3
branch
from
789c5c8 to
812b802
Compare
yosefe
approved these changes
Nov 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.