fix(crowdin_validator): skip validation on crowdin_sync's own PRs - #12
Merged
Merged
Conversation
crowdin_pull's self-heal PRs (rolling branch chore/crowdin-sync) mirror whatever Crowdin currently has, including legitimate deletions/edits made via the Crowdin UI/API -- exactly what this validator otherwise exists to block for hand-edited PRs. Without this, crowdin_pull's own PRs get blocked by the very validator meant to protect Crowdin as the source of truth, whenever Crowdin-side content is removed or changed. Caught live: deleted a test string via the Crowdin API, crowdin_pull correctly opened a PR reflecting the removal (#11), but crowdin_validator failed it with "existing string(s) deleted outside the Crowdin UI" -- even though the deletion *was* via the Crowdin UI/API, just reflected through crowdin_pull rather than hand-edited. Detect the PR's head branch via BITRISE_GIT_BRANCH (Bitrise checks PRs out as a detached merge ref, so git itself can't tell) and skip entirely when it matches crowdin_sync.py's rolling branch name.
anthonyraj
pushed a commit
that referenced
this pull request
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
`crowdin_pull`'s own self-heal PRs (rolling branch `chore/crowdin-sync`) mirror whatever Crowdin currently has -- including legitimate deletions/edits made via the Crowdin UI/API. That's exactly what `crowdin_validator` otherwise exists to block for hand-edited PRs, so without this fix, `crowdin_pull`'s own PRs get blocked by the very validator meant to protect Crowdin as the source of truth, any time something is removed/changed on Crowdin's side.
Caught live
Fix
Detect the PR's head branch (via `BITRISE_GIT_BRANCH` -- Bitrise checks PRs out as a detached merge ref, so plain git can't tell) and skip validation entirely when it matches `crowdin_sync.py`'s rolling branch name (`chore/crowdin-sync`, or `CROWDIN_SYNC_BRANCH` if overridden).
Next step after merge
Re-trigger/rebuild #11's `crowdin_validator` check -- it should pass once this fix is on `main`, since PR checks use the merge-ref against current `main`.