chore: automate language support - #309
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 35e7fc0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Use indexed import bindings and quoted locale keys so codes like pt-BR do not break the generated i18n resources module. Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Cameron Llewellyn <cameron.b.llewellyn@gmail.com>
Emit unquoted locale keys for valid identifiers and single-quoted keys for region tags (e.g. pt-BR) so lint-staged Prettier no longer drifts resources.generated.ts. Detect registration via import paths in the parity check instead of a quoted-key substring.
Collaborator
Author
|
@greptile-apps can you review again and update your ratting? |
Ensures local typecheck and Storybook use an up-to-date locale map. Co-authored-by: Cursor <cursoragent@cursor.com>
Avoid constructing invalid tags like pt-BR-PT-BR when supported locales already include a region, and add a changeset for the automated locale registration work.
cameronapak
previously approved these changes
Jul 30, 2026
cameronapak
left a comment
cameronapak
left a comment
Collaborator
There was a problem hiding this comment.
This looks great and I had one comment cause I think a file that pushed that didn't need to be pushed
bmanquen
reviewed
Jul 31, 2026
bmanquen
previously approved these changes
Jul 31, 2026
bmanquen
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
Automates UI locale registration and keeps generated i18n resources synchronized.
Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR A["Locale JSON files"] --> B["generate-i18n-resources.mjs"] B --> C["resources.generated.ts"] C --> D["i18n instance"] D --> E["Browser-language resolution"] B -. watch mode .-> F["Development / Storybook reload"] C --> G["Build, tests, and typecheck"]Reviews (11): Last reviewed commit: "fix: change script and add notes" | Re-trigger Greptile
Context used: