Skip to content

test: migrate tests to rstest#13799

Merged
chenjiahan merged 3 commits intoyouzan:mainfrom
9aoy:rstest
Mar 26, 2026
Merged

test: migrate tests to rstest#13799
chenjiahan merged 3 commits intoyouzan:mainfrom
9aoy:rstest

Conversation

@9aoy
Copy link
Contributor

@9aoy 9aoy commented Mar 26, 2026

migrate tests to rstest.

https://rstest.rs/

before:
image

after:
image

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant refactoring of the project's testing infrastructure by migrating from Vitest to rstest. This change aims to leverage the features and performance benefits of the rstest framework, streamlining the testing process and ensuring future compatibility. The migration involved updating core test configurations, dependencies, and adapting existing test files to the new framework's API, while maintaining the integrity and coverage of the test suite.

Highlights

  • Test Framework Migration: Migrated the test suite from Vitest to rstest, updating configuration files, script commands, and test utility functions across the codebase.
  • Dependency Updates: Updated package.json to replace Vitest-related development dependencies with their rstest and rsbuild equivalents, ensuring compatibility with the new testing environment.
  • Snapshot Format Update: Updated all existing snapshot files to reflect the change from Vitest to Rstest, ensuring consistency with the new testing framework.
  • SSR Test Environment Configuration: Introduced a new rstest.config.mts file to define rstest configurations, including specific settings for client and server-side rendering (SSR) test environments.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.46%. Comparing base (ec5b45b) to head (a2864b0).
⚠️ Report is 214 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13799      +/-   ##
==========================================
- Coverage   89.60%   89.46%   -0.15%     
==========================================
  Files         257      257              
  Lines        7013     6671     -342     
  Branches     1736     1666      -70     
==========================================
- Hits         6284     5968     -316     
+ Misses        384      372      -12     
+ Partials      345      331      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the project's testing framework from Vitest to Rstest. This involved updating package dependencies, modifying test scripts, and replacing Vitest-specific utility calls (e.g., vi.fn() to rs.fn()) across numerous test files. A new rstest.config.mts file was added, and existing snapshot headers were updated to reflect the change. A minor improvement opportunity was noted in the rstest.config.mts file regarding a redundant include property.

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@chenjiahan chenjiahan merged commit 368b226 into youzan:main Mar 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants