parse: bump ParserV for the title change; ignore <synthetic> model ids - #18
Merged
Conversation
The title-derivation change shipped without a ParserV bump, so entries scanned by an older binary — fully scanned, junk title, same version — were trusted forever; a file that stopped growing never re-titled. The field case: a stale `agentdash -w` from before the upgrade kept rewriting the cache with old-parser entries every tick, and the new binary accepted them. v7 forces the one-time rescan; derivation changes, not just new fields, now warrant a bump (comment updated). Also: "<synthetic>" — the model id on system-generated claude messages — no longer displaces the session's real model (a board row rendered "<syntheti…" in the MODEL column). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defects (both caught verifying the D round on the devbox)
ParserV, so entries scanned by an older binary (fully scanned, junk title, samev:6) were trusted forever. Field case that surfaced it: a staleagentdash -wrunning since before the upgrade rewrote the cache with old-parser entries every refresh tick, and the new binary accepted every one.ParserV→ 7 forces the one-time rescan; the constant's comment now says derivation changes, not just new fields, warrant a bump.<synthetic>in the MODEL column. System-generated claude messages carry model"<synthetic>", which displaced the session's real model (a live row rendered<syntheti…). Now ignored; a session with only synthetic messages reports no model.Evidence
TestOldParserVersionEntryIsRescannedreplays the stale-watcher case (old-V entry with junk title, unchanged file → rescanned, correct title).TestSyntheticModelDoesNotDisplaceRealcovers both orders and the synthetic-only case.go test ./... -race, fuzz 15s, vet, golangci 0 issues, parity, bats, darwin build.🤖 Generated with Claude Code