feat(settings): add in-app language switcher - #175
Merged
Conversation
added 2 commits
August 2, 2026 01:23
The language preference already existed in the settings repository but was never surfaced in the UI or applied at runtime. Add a Language row to the settings screen backed by a radio dialog, apply the chosen locale in the Application and both Activities via attachBaseContext, and recreate the activity so the change takes effect immediately. Also correct the README, which claimed a bilingual (EN/JA) UI while the app ships eight localized string sets (en, ja, zh-CN, ru, es, fr, pt-BR, ar).
The translation check requires every source key to exist in all values-* files. Add the language selector strings (translated row/dialog/system labels, plus native display names) to all seven locales.
Contributor
|
Debug APK built successfully Download APK artifact Commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
languagepreference already existed in the settings repository but was never surfaced in the UI or applied at runtime.Changes
Languagerow (Appearance section) with a radio dialog listing all supported locales, defaulting toSystem default.attachBaseContextinAndCodeApplication,MainActivity, andQuickInputActivitythrough a newAppLanguagehelper; selecting a language recreates the activity so it takes effect immediately.Bilingual — English and Japanese UIclaim with the actual 8 supported locales (en, ja, zh-CN, ru, es, fr, pt-BR, ar) in both README.md and README.ja.md.