Socket ended without exit message

[Ercilan]

If I call ptyProcess.kill(), it always throws an error:

Socket ended without exit message

What is the correct way to close it? Or is this a bug?

[yume-chan]

It's by design: https://tangoadb.dev/api/adb/subprocess/shell-protocol/#kill

Calling kill closes the socket, which triggers ADB daemon to send a SIGHUP to the child process. The child process may handle the signal and exit with its own exit code, or the kernel kills the process with exit code 129. But as the socket is already closed, this exit code can't be received, so the exited promise always rejects with that error.

You can use a variable to differentiate between you killing the process or the ADB connection breaks.

I'm also open to any suggestions on this API design.

[yume-chan]

I added a more detailed explanation in https://tangoadb.dev/api/adb/subprocess/shell-protocol/#exited-promise-behavior

[Ercilan]

I added a more detailed explanation in https://tangoadb.dev/api/adb/subprocess/shell-protocol/#exited-promise-behavior

By the way, there is a spelling mistake in the documentation: it should be WritableStream instead of WriteableStream.

[yume-chan]

Thanks! All fixed!