Add claude GitHub actions 1780988023695#3
Merged
Conversation
yuu61
added a commit
that referenced
this pull request
Jun 10, 2026
コード全体のレビューで検出した論理・契約・セキュリティ上の問題を修正。 各修正にテストを追加し、make check / test-race / cross をすべて緑で確認。 ping: - routeros: IPv6 中継ホストを URL でブラケットし、url.Parse 失敗（毎回 Failed）を防止 (#1) - routeros: http.Client を pinger に保持して再利用、毎 Send の接続/goroutine リークを解消 (#2) - routeros: verify を寛容な bool に。yes/1/on/不明値は secure 既定とし、フェイルオープンを解消 (#4) - snmp/hping/routeros: 非対応な source= を起動時警告で案内（無音無視を解消、監視は継続）(#8) - parse: snmp/hping の RTT 正規表現を小数対応に。sub-1ms の切り捨てを解消 (#6) - parse: RouterOS min-rtt を s/ms/us の合算に。whole-ms ("5ms") の取りこぼしを解消 (#10) - subprocess/osname: IPv6 の ping コマンドを os= 属性で選択（Darwin は別 ping6、他は現行 OS の統合 ping -6）。リモート実行コマンドをローカル LookPath で決める依存を解消 (#7) config: - インデントした "#" 行コメントを除去し、コメントアウトしたホストの誤 ping を防止 (#3) - ディレクティブ語（columns/scale/precision/split）を大小無視の予約語に (#9) - quote-aware な ";#" トレーラ除去で、引用符内の値中の ";#" を保護 (#11) monitor: - ログに up/down 状態と %.3f を導入。失敗時に直前成功の stale RTT を記録する問題を解消 (#5) tui: - 端末高さが固定ヘッダ未満のときヘッダがあふれてタイトルが落ちる問題をクランプで防止 (#15) cmd: - --help / -h を exit 0 に（従来は exit 2 + "flag: help requested"）(#12) docs: - README の Go バージョン要件を go.mod の 1.25 に一致 (#14) - source / verify の対応モードと綴り、予約ディレクティブ語の契約を正確化 (#13「凡例に h/a を追加」は撤回。簡潔な凡例は設計どおりで、h/a は README に記載済み)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.