Skip to content

fix(instructions): prevent special parameter name collisions - #547

Merged
ss-o merged 1 commit into
mainfrom
code/zsh-special-parameters
Aug 27, 2026
Merged

fix(instructions): prevent special parameter name collisions#547
ss-o merged 1 commit into
mainfrom
code/zsh-special-parameters

Conversation

@ss-o

@ss-o ss-o commented Aug 27, 2026

Copy link
Copy Markdown
Member

Summary

  • add a required Zsh rule that prevents unrelated local or scratch data from
    reusing shell-owned special parameter names
  • document the concrete status and path failure modes and recommend
    purpose-specific names
  • synchronize policy metadata, validator inventories, startup membership, and
    deterministic regression coverage

Closes #546

Instruction impact review

  1. Classification: scoped normative Zsh guidance plus existing
    machine-readable enforcement metadata.
  2. Consumers and contexts: Codex, Claude Code, Copilot, Gemini CLI, and
    human contributors working with enrolled Zsh source in all five execution
    profiles.
  3. Canonical owner: .github/instructions/zsh-scripting.instructions.md
    remains the prose owner; lib/zsh-standard-policy.json remains the metadata
    owner.
  4. Duplication or contradiction: none found. Existing rules cover explicit
    scope and dynamic scope, not collisions with special parameter names.
  5. Manifest routing: unchanged. The existing instruction-zsh-scripting
    route already reaches the affected paths and consumers.
  6. Runtime delivery: all supported runtimes receive the mandatory scoped
    instruction without relying on an optional hook or skill.
  7. Generated output and limits: the public policy validators pass, and the
    private generated root composite is unaffected because neither imported
    baseline policy nor the private overlay changes.

Verification

  • python3 -m unittest scripts/test_validate_zsh_standard_policy.py -v
    (99 tests passed)
  • python3 -m unittest scripts/test_validate_agent_policy.py -v
    (83 tests passed)
  • python3 scripts/validate-zsh-standard-policy.py
  • python3 scripts/validate-agent-policy.py
  • git diff --check

The rule semantics were checked against the released Zsh Parameters manual and
confirmed with isolated zsh -f probes.

@ss-o
ss-o requested a review from a team as a code owner August 27, 2026 15:01
@ss-o ss-o closed this Aug 27, 2026
@ss-o ss-o reopened this Aug 27, 2026
@ss-o
ss-o merged commit 0b58834 into main Aug 27, 2026
9 of 10 checks passed
@ss-o
ss-o deleted the code/zsh-special-parameters branch August 28, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent Zsh special parameter name collisions in scoped guidance

1 participant