chore(repo): sync plugin review hotfix - #847
Merged
Merged
Conversation
release: promote next to main
release: promote next to main
* fix(ci): provision Zsh for standard review * chore(ci): refresh hotfix checks --------- Co-authored-by: Sal <ss-o@users.noreply.github.com>
Deploying zsh with
|
| Latest commit: |
2950c2c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://64af4090.zsh.pages.dev |
| Branch Preview URL: | https://hotfix-845-sync.zsh.pages.dev |
Contributor
There was a problem hiding this comment.
Pull request overview
Synchronizes the production hotfix for the “Zsh Plugin Standard Review” workflow into next, ensuring the workflow reliably provisions a zsh binary and that the repository’s semantic workflow contract tests enforce this requirement.
Changes:
- Adds an explicit “Install Zsh” step to the
plugin-standard-reviewGitHub Actions workflow. - Extends the semantic workflow validator to require the Zsh provisioning step (exact command + ordering).
- Updates/extends regression tests to cover Zsh provisioning and step ordering constraints.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
scripts/validate-plugin-standard.test.mjs |
Updates step indices and adds tests to reject removal/mutation/misordering of the new Zsh provisioning step. |
scripts/validate-plugin-standard.mjs |
Adds “Install Zsh” to the required workflow step sequence and adjusts step extraction to match the new ordering. |
.github/workflows/plugin-standard-review.yml |
Provisions Zsh on the Ubuntu runner before running deterministic validation. |
Suppressed comments (1)
scripts/validate-plugin-standard.mjs:354
validateWorkflowcan throw a TypeError when a malformed workflow keeps the expectedstepsarray length but containsnull/non-object entries (valid YAML), because it accessessetupNodeStep.withandissueStep.envwithout guarding against non-record steps. Since this function is meant to validate untrusted workflow content, it should never crash; it should return errors instead.
const [, , setupNodeStep, , , , issueStep] = steps;
if (
!hasExactKeys(setupNodeStep.with, ["node-version", "cache"]) ||
setupNodeStep.with["node-version"] !== "22" ||
setupNodeStep.with.cache !== "pnpm"
) {
errors.push("Node setup must use Node 22 with the pnpm cache");
}
if (!hasExactKeys(issueStep.env, ["GH_TOKEN"]) || issueStep.env.GH_TOKEN !== GITHUB_TOKEN_EXPRESSION) {
errors.push("review issue step must use the repository-scoped GitHub token");
}
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ss-o
enabled auto-merge (squash)
August 15, 2026 12:45
ss-o
disabled auto-merge
August 15, 2026 12:45
Contributor
|
Size Change: -38 B (0%) Total Size: 6.66 MB 📦 View Changed
ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainintonextto preserve the production hotfix historynextfrom build(deps): bump the react group across 1 directory with 4 updates #825, build(deps-dev): bump @cloudflare/workers-types from 5.20260723.1 to 5.20260812.1 #827, and build(deps-dev): bump the linting group across 1 directory with 3 updates #828@types/node26.2.0 from build(deps-dev): bump the typescript group across 1 directory with 2 updates #831 while restoring TypeScript 6.0.3 becausetypescript-eslintrequires TypeScript<6.1.0Validation
pnpm validate:plugin-standardpnpm wrangler:typecheckpnpm exec trunk check --ci --no-fix --verbose --print-failures --upstream=origin/next.github/workflows/plugin-standard-review.ymlgit diff --check origin/next...HEADReconciles #845.
Related to #843 and #831.
Closes #849.