Refactor secrets rotation classes - #37
Merged
Merged
Conversation
…ciated references
…yService.setSecrets`
- Add `updatePassword` method to `SecretsRotationService` for standalone password changes - Update `SecretsRotationService` to ensure `CryptoSecrets` are destroyed after use to improve memory safety - Refactor dependency injection to pass `DatabaseManager` directly to rotation methods - Use `IllegalArgumentException` for secret validation failures - Update `SecretsRotationAndroidService` and tests to reflect the new service interface
…or getActualSecrets method
…lated classes and XMLs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the secrets rotation architecture by replacing direct
CryptoManagerdependencies withAppSecurityServiceintegration. It includes renaming changes from "re-encryption" to "secrets rotation" terminology and moving the secrets rotation logic to a new rotation package structure.