Isolate daemon environments and expose PID-safe tree kill - #653
Merged
Conversation
zackees
marked this pull request as ready for review
July 23, 2026 23:28
This was referenced Jul 23, 2026
Owner
Author
|
Consumer rollouts: zackees/soldr#1793, FastLED/fbuild#1169, and zackees/zccache#1192. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnvironmentPolicy::{Auto, Inherit, UserBaseline, Clear}to contained and detached spawn APIsAutoinherit for contained children and build a fresh Windows user baseline for detached daemonsprocess_tree::kill_tree(pid, timeout)without requiring the daemonSafety boundary
Windows does not expose a supported readback API for the original
CreateProcesscreation flags of an arbitrary process. This change therefore does not infer daemon intent or broadly reap detached-looking processes. It supplies explicit spawn policy plus a PID-instance-safe tree-kill primitive for callers that already have lifecycle ownership.Validation
soldr cargo test -p running-process --lib --no-default-features environment -- --test-threads=1soldr cargo test -p running-process --test containment_test test_auto -- --test-threads=1soldr cargo test -p running-process --test containment_test test_local_kill_tree -- --test-threads=1soldr cargo check -p running-process --all-features --libgit diff --checksoldr cargo fmt --all -- --checkis already red on unchangedorigin/mainfiles under the current toolchain; all touched Rust files were formatted individually.