access to csi::io::indexed_records::record::Record

[brentp]

Hi, I'd like to use csi (or tabix) to get data and I can get the IndexedRecord trait items, but I'd like to downcast to the Record so I can get to fields other than those in IndexedRecord.
If I am not mistaken, Record is indeed public, but there is no way to access it.
I try, for example:

use noodles::csi::io::indexed_records::record::Record;

and see:

module `indexed_records` is private
...
lib.rs(455, 40): module `record` is not publicly re-exported
io.rs(6, 1): the module `indexed_records` is defined here

Perhaps I miss something, but I think adding

pub use self::indexed_records::record::Record

to io.rs would suffice. If you agree, I can make a PR.

[zaeleus]

Thanks for reporting. Let's increase the visibility of the csi::io::indexed_records module, which will give access to csi::io::indexed_records::Record.

[brentp]

#323

[brentp]

With that change, is this how to access Record?

                if let Some(concrete_record) = (&record as &dyn Any).downcast_ref::<Record>() {
                    let buf = concrete_record.as_ref();
                    /* parse buf into my own record */

[zaeleus]

Ah, I see. Note that the iterator that IndexedRecords::filter_by_region returns is not generic over R (IndexedRecord) but returns a concrete Record. Your BedRecordIterator<I> should also be I: Iterator<Item = io::Result<Record>> + 'r instead of generic over R. With this change, you don't have to downcast the record.

[brentp]

that makes sense! thanks very much!

[brentp]

and just to verify, there's no way for me to implement the IndexedRecord trait on my BedRecord and skip Record entirely, is there?

[brentp]

I guess that would be pretty magical or require method in the trait to parse from str.

[zaeleus]

Yes, since you require the underlying string, you need a Record, not an implementation of IndexedRecord.