Move nil EndpointSlice conditions in isReady#4136
Merged
MustafaSaber merged 1 commit intoJul 16, 2026
Merged
Conversation
Signed-off-by: shrikant23codes <jiturishrikant@gmail.com>
MustafaSaber
approved these changes
Jul 16, 2026
szuecs
approved these changes
Jul 16, 2026
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move nil EndpointSlice conditions handling into
EndpointSliceEndpoints.isReady().EndpointSlice endpoints with missing conditions is already treated as ready. So instead of having this check outside isReady moved it within.
This makes the
isReadyfunction handle all cases and avoids requiring future callers to duplicate the nil-condition check.Tests
Suggested label: refactor or bugfix (actually not a bug)
Fixes #4137