Skip to content

Fixes #600 - Add init: true to scheduler and railsserver to prevent zombie process accumulation - #602

Merged
mgruner merged 1 commit into
masterfrom
issue-600-docker-init-pid1
Jul 30, 2026
Merged

Fixes #600 - Add init: true to scheduler and railsserver to prevent zombie process accumulation#602
mgruner merged 1 commit into
masterfrom
issue-600-docker-init-pid1

Conversation

@mgruner

@mgruner mgruner commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@mgruner
mgruner requested review from derpixler and fliebe92 July 30, 2026 05:40
@mgruner mgruner self-assigned this Jul 30, 2026
@mgruner

mgruner commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator Author

@derpixler @fliebe92 what do you think about this? Since this behaviour affects all containers running the Rails stack, I would suggest to add init: true to the shared service definition, and disabling it only for zammad-nginx, which does not run the rails stack.

If you agree, I would think that a small UAT might be good to ensure there is no negative behaviour change. @ralf401 could you help here?

@fliebe92

Copy link
Copy Markdown
Collaborator

@derpixler @fliebe92 what do you think about this? Since this behaviour affects all containers running the Rails stack, I would suggest to add init: true to the shared service definition, and disabling it only for zammad-nginx, which does not run the rails stack.

If you agree, I would think that a small UAT might be good to ensure there is no negative behaviour change. @ralf401 could you help here?

Sounds good to me.

@derpixler

derpixler commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@mg it is smarter as my suggestion, go ahead.

@ralf401

ralf401 commented Jul 30, 2026

Copy link
Copy Markdown

@mgruner I played a bit around after deploying a stack from this PR and setting up a dummy email server. Didn't notice any unexpected behavior. However, not sure it I tested every important aspect. I just triggered some email notifications and checked the processes on the railsserver. Result: PID was 2403 in my case (docker-init got 1) and I could not see any duplicated processes.

Let me know if you think I should test additional stuff and/or wait longer to confirm no zombie process exists.

@mgruner

mgruner commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator Author

Awesome, thank you @ralf401

@mgruner
mgruner merged commit fc82e17 into master Jul 30, 2026
13 checks passed
@mgruner
mgruner deleted the issue-600-docker-init-pid1 branch July 30, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants