Open
Conversation
Contributor
Author
|
@zaphoyd any chance of merging this one? |
|
@yeswalrus I think maybe the one I submitted moments ago might be more What do you think? |
Contributor
Author
|
Bit late to reply, but no. This uses the cmake official recommended way for creating config files, while your PR doesn't really provide the same functionality, and doesn't follow cmake config file best practices. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes packages created by the cmake install step relocatable which is very useful for a build/deploy standpoint, and adds a websocketpp interface target for CMake 3.x users without breaking compatibility for older versions.