Check for the version in Server Header Disclosure #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekrana-getastra
force-pushed
the
version-leak-found
branch
from
4e95f11 to
e1e185e
Compare
thc202
changed the title
kingthorin
requested changes
Jul 3, 2022
thc202
reviewed
Jul 3, 2022
thc202
reviewed
Jul 3, 2022
Member
|
The changelog should be updated. |
prateekrana-getastra
force-pushed
the
version-leak-found
branch
from
3fc38aa to
b11a4b9
Compare
|
This pull request introduces 1 alert when merging b11a4b9 into d4d4b92 - view on LGTM.com new alerts:
|
prateekrana-getastra
force-pushed
the
version-leak-found
branch
from
85e0f79 to
34b99ad
Compare
kingthorin
reviewed
Jul 4, 2022
prateekrana-getastra
force-pushed
the
version-leak-found
branch
from
9ace767 to
204019b
Compare
Author
Changes to be added under Unreleased? |
Member
|
Yes, for this one: Under Unreleased, in the |
kingthorin
reviewed
Jul 4, 2022
prateekrana-getastra
force-pushed
the
version-leak-found
branch
from
4099b43 to
d0b852c
Compare
Author
|
Anything else to update? |
prateekrana-getastra
force-pushed
the
version-leak-found
branch
from
521ecd8 to
4ab82b9
Compare
kingthorin
force-pushed
the
version-leak-found
branch
2 times, most recently
from
6dd9465 to
7913cd1
Compare
Signed-off-by: Prateek rana <prateekrana1519@gmail.com>
kingthorin
force-pushed
the
version-leak-found
branch
from
7913cd1 to
91f22e8
Compare
kingthorin
approved these changes
Jul 7, 2022
Member
git fetch origin
git reset --hard origin/version-leak-found |
thc202
approved these changes
Jul 7, 2022
Member
|
Thank you both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Alert Description states about leaking version information via the http header. The previous version for the script only checks for the header without considering whether even the version is leaked or not. Added checks for looking up numeric versions information available in the http header.