Skip to content

create a repository in a group#378

Closed
kovetskiy wants to merge 3 commits intozaquestion:masterfrom
kovetskiy:master
Closed

create a repository in a group#378
kovetskiy wants to merge 3 commits intozaquestion:masterfrom
kovetskiy:master

Conversation

@kovetskiy
Copy link
Copy Markdown
Contributor

@kovetskiy kovetskiy commented May 20, 2020

this feature allows specifying namespace name while creating a repository

@claytonrcarter
Copy link
Copy Markdown
Collaborator

Thanks! This is glorious, and so simple! Works as expected and a long overdue addition. I believe that this could close #211, too.

Although I think this would be fine to merge as is, I do have a couple of nitpicky things:

  1. The "Long" comment on line 21 of project_create can be updated to remove "in your user namespace"
  2. I would love to see a comment clarifying that leaving namespaceID unassigned will default to the users current namespace. Maybe it's just me, but I had to double check that I wasn't missing something that looked up my namespace if -g wasn't used. (FWIW, NamespaceID is flagged with omitempty in CreateProjectOptions)

But again, this is great! Thanks again!

@kovetskiy
Copy link
Copy Markdown
Contributor Author

Here you go, feel free to squash the commits

@claytonrcarter claytonrcarter linked an issue May 25, 2020 that may be closed by this pull request
@claytonrcarter
Copy link
Copy Markdown
Collaborator

Thank you, @kovetskiy!

@zaquestion I can't merge because it looks like Travis is stuck, but this looks like it's good to go and ready for merge.

@kovetskiy
Copy link
Copy Markdown
Contributor Author

@claytonrcarter any chance to merge the PR?

@kovetskiy
Copy link
Copy Markdown
Contributor Author

kovetskiy commented May 29, 2020

ping @zaquestion
@claytonrcarter

@claytonrcarter
Copy link
Copy Markdown
Collaborator

Sorry for the delay; there is a high chance of merging the PR, but my hands are currently tied. I don't have perm to merge if CI is stuck or doesn't pass, and that's where we are. We'll get it in, though; don't worry, but please be patient. Thanks for understanding.

@kovetskiy
Copy link
Copy Markdown
Contributor Author

@zaquestion ping

@kovetskiy
Copy link
Copy Markdown
Contributor Author

@claytonrcarter
Hi, I'm closing this PR because I need to implement more features to work with GitLab more effectively.

I'll be glad to merge new features back to upstream when maintainers of lab come back, but for now, I'm going to maintain my own fork. Thanks.

@kovetskiy kovetskiy closed this Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FR: lab project create for a different namespace

2 participants