Skip to content

mr_list: fix help message wrt MR state#593

Merged
bmeneg merged 2 commits intozaquestion:masterfrom
bmeneg:fix-mr_list-help
Feb 17, 2021
Merged

mr_list: fix help message wrt MR state#593
bmeneg merged 2 commits intozaquestion:masterfrom
bmeneg:fix-mr_list-help

Conversation

@bmeneg
Copy link
Copy Markdown
Collaborator

@bmeneg bmeneg commented Feb 17, 2021

Add all to the lab mr list --help command under -s, --state string paramenter.
With that the user don't need to guess this option is available.

It's also possible to request the mr_list command to list MRs in any state
(`all` as defined by gitlab API). This patch adds this information to the
help message, so the user don't need to guess it.

Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 17, 2021

Codecov Report

Merging #593 (02e44ae) into master (27f0557) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #593      +/-   ##
==========================================
- Coverage   57.57%   57.48%   -0.10%     
==========================================
  Files          67       67              
  Lines        4337     4337              
==========================================
- Hits         2497     2493       -4     
- Misses       1600     1603       +3     
- Partials      240      241       +1     
Impacted Files Coverage Δ
cmd/issue_list.go 79.66% <100.00%> (ø)
cmd/mr_list.go 75.53% <100.00%> (ø)
cmd/fork.go 53.84% <0.00%> (-5.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27f0557...02e44ae. Read the comment docs.

@fmuellner
Copy link
Copy Markdown
Contributor

I guess the same should be done for issue list.

It's also possible to request the issue_list command to list issues in any
state (`all` as defined by gitlab API). This patch adds this information to
the help message, so the user don't need to guess it.

Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
@bmeneg bmeneg merged commit f3c8fb2 into zaquestion:master Feb 17, 2021
@bmeneg bmeneg deleted the fix-mr_list-help branch February 24, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants