mr,issue,snippet: make shorthand flags deprecated#629
Merged
bmeneg merged 1 commit intozaquestion:masterfrom Mar 10, 2021
Merged
mr,issue,snippet: make shorthand flags deprecated#629bmeneg merged 1 commit intozaquestion:masterfrom
bmeneg merged 1 commit intozaquestion:masterfrom
Conversation
All commands with --list, --close and --browse flags, also has the actual subcommand for each of them. I've seen users getting confused because the flags in the `list` command can't be used with the shorthand, and tbh, typing `list` is easier than `--list` (the same is valid for the others flags). IMHO the shorthand as a whole should be deprecated, avoiding user confusion and, possibly, dead code for getting maintained. Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #629 +/- ##
==========================================
- Coverage 57.29% 56.14% -1.15%
==========================================
Files 71 73 +2
Lines 4519 4613 +94
==========================================
+ Hits 2589 2590 +1
- Misses 1686 1772 +86
- Partials 244 251 +7
Continue to review full report at Codecov.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate shorthand flags directly in the commands (mr, issue and snippet).
These shorthands don't really work as expected: the flags from the subcommands are not available for them, so it has been basically a shorthand for the default behavior of a subcommand:
lab mr list==lab mr --list, and that's it. IMHO, the subcommand is easier to type than the shorthand, so I don't think it makes sense to keep them around.