cmd/edit: check if --force-linebreak coming from CLI or config #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When --force-linebreak is set through the config file the conditional
for opening the editor will always be satisfied no matter what's the
other flag being used together, since it only requires NFlag() == 1 and
linebreak being set.
For instance:
lab.toml:
[mr_edit]
force-linebreak = true
cli:
$ lab mr edit --ready
[EDITOR IS OPENED]
This patch fixes it by checking it linebreak is being actually set
through the CLI, so in case NFlag() == 1 we're sure the user wants to
open the editor considering the "force-linebreak".
Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #791 +/- ##
==========================================
- Coverage 55.07% 55.02% -0.06%
==========================================
Files 77 77
Lines 5641 5656 +15
==========================================
+ Hits 3107 3112 +5
- Misses 2255 2263 +8
- Partials 279 281 +2
Continue to review full report at Codecov.
|
zampierilucas
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When --force-linebreak is set through the config file the conditional
for opening the editor will always be satisfied no matter what's the
other flag being used together, since it only requires NFlag() == 1 and
linebreak being set.
For instance:
lab.toml:
[mr_edit]
force-linebreak = true
cli:
$ lab mr edit --ready
[EDITOR IS OPENED]
This patch fixes it by checking it linebreak is being actually set
through the CLI, so in case NFlag() == 1 we're sure the user wants to
open the editor considering the "force-linebreak".
Signed-off-by: Bruno Meneguele bmeneg@redhat.com
Related: #790